From 174cf2f7476224c167608290d27eac846834dace Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Fri, 13 May 2022 16:50:52 -0700 Subject: [PATCH] [lldb/API] Turn SBCompileUnit::GetIndexForLineEntry into FindLineEntryIndex (NFC) This patch renames the `SBCompileUnit::GetIndexForLineEntry` api to be an overload of `SBCompileUnit::FindLineEntryIndex` Differential Revision: https://reviews.llvm.org/D125594 Signed-off-by: Med Ismail Bennani --- lldb/bindings/interface/SBCompileUnit.i | 4 ++-- lldb/include/lldb/API/SBCompileUnit.h | 4 ++-- lldb/source/API/SBCompileUnit.cpp | 4 ++-- lldb/test/API/python_api/compile_unit/TestCompileUnitAPI.py | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lldb/bindings/interface/SBCompileUnit.i b/lldb/bindings/interface/SBCompileUnit.i index a633ee7..5a03069 100644 --- a/lldb/bindings/interface/SBCompileUnit.i +++ b/lldb/bindings/interface/SBCompileUnit.i @@ -79,9 +79,9 @@ public: @return The index of the user-provided line entry. UINT32_MAX if the line entry - was not found in the compile unit.") GetIndexForLineEntry; + was not found in the compile unit.") FindLineEntryIndex; uint32_t - GetIndexForLineEntry (lldb::SBLineEntry &line_entry, bool exact = false) const; + FindLineEntryIndex (lldb::SBLineEntry &line_entry, bool exact = false) const; uint32_t FindLineEntryIndex (uint32_t start_idx, diff --git a/lldb/include/lldb/API/SBCompileUnit.h b/lldb/include/lldb/API/SBCompileUnit.h index 18da48b..36492d9 100644 --- a/lldb/include/lldb/API/SBCompileUnit.h +++ b/lldb/include/lldb/API/SBCompileUnit.h @@ -34,8 +34,8 @@ public: lldb::SBLineEntry GetLineEntryAtIndex(uint32_t idx) const; - uint32_t GetIndexForLineEntry(lldb::SBLineEntry &line_entry, - bool exact = false) const; + uint32_t FindLineEntryIndex(lldb::SBLineEntry &line_entry, + bool exact = false) const; uint32_t FindLineEntryIndex(uint32_t start_idx, uint32_t line, lldb::SBFileSpec *inline_file_spec) const; diff --git a/lldb/source/API/SBCompileUnit.cpp b/lldb/source/API/SBCompileUnit.cpp index 610860f..3aa65e2 100644 --- a/lldb/source/API/SBCompileUnit.cpp +++ b/lldb/source/API/SBCompileUnit.cpp @@ -77,8 +77,8 @@ SBLineEntry SBCompileUnit::GetLineEntryAtIndex(uint32_t idx) const { return sb_line_entry; } -uint32_t SBCompileUnit::GetIndexForLineEntry(lldb::SBLineEntry &line_entry, - bool exact) const { +uint32_t SBCompileUnit::FindLineEntryIndex(lldb::SBLineEntry &line_entry, + bool exact) const { LLDB_INSTRUMENT_VA(this, line_entry, exact); if (!m_opaque_ptr || !line_entry.IsValid()) diff --git a/lldb/test/API/python_api/compile_unit/TestCompileUnitAPI.py b/lldb/test/API/python_api/compile_unit/TestCompileUnitAPI.py index 2c4ebf7..9f7de01 100644 --- a/lldb/test/API/python_api/compile_unit/TestCompileUnitAPI.py +++ b/lldb/test/API/python_api/compile_unit/TestCompileUnitAPI.py @@ -37,7 +37,7 @@ class CompileUnitAPITestCase(TestBase): main_cu = sc_list.compile_units[0] self.assertTrue(main_cu.IsValid(), "Main executable CU is not valid") - self.assertEqual(main_cu.GetIndexForLineEntry(line_entry, True), + self.assertEqual(main_cu.FindLineEntryIndex(line_entry, True), main_cu.FindLineEntryIndex(0, line_entry.GetLine(), line_entry.GetFileSpec(), True)) -- 2.7.4