From 17084b6f9340f798111e53e08f5d35c7630cee48 Mon Sep 17 00:00:00 2001 From: Chad Versace Date: Tue, 27 Sep 2016 23:06:37 -0700 Subject: [PATCH] egl: Fix missing unlock in eglGetSyncAttribKHR On the error path, eglGetSyncAttribKHR neglected to unlock the EGLDisplay before returning. Fixes deadlock in dEQP-EGL.functional.fence_sync.invalid.get_invalid_value. Cc: mesa-stable@lists.freedesktop.org Cc: Mark Janes Reviewed-by: Emil Velikov --- src/egl/main/eglapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 1c62a80..44fc0b8 100644 --- a/src/egl/main/eglapi.c +++ b/src/egl/main/eglapi.c @@ -1602,7 +1602,7 @@ eglGetSyncAttribKHR(EGLDisplay dpy, EGLSync sync, EGLint attribute, EGLint *valu EGLBoolean result; if (!value) - RETURN_EGL_ERROR(NULL, EGL_BAD_PARAMETER, EGL_FALSE); + RETURN_EGL_ERROR(disp, EGL_BAD_PARAMETER, EGL_FALSE); attrib = *value; result = _eglGetSyncAttribCommon(disp, s, attribute, &attrib); -- 2.7.4