From 16a1ef7860e4f0ce27faceb6874870d8d6fd5a56 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Alejandro=20Pi=C3=B1eiro?= Date: Thu, 16 May 2019 11:32:23 +0200 Subject: [PATCH] docs: advice to resolve discussion on gitlab MR doc For newcomers to gitlab, it is not evident that it is better to press the "Resolve Discussion" button when you update your branch handling feedback. v2: * Fix several grammar nits, reorder, use new corrected text (Connor Abbot) * Use "reviewers", instead of reviewer (Eric Engestrom) Reviewed-by: Connor Abbott Reviewed-by: Eric Engestrom --- docs/submittingpatches.html | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html index 020e73d..48cc676 100644 --- a/docs/submittingpatches.html +++ b/docs/submittingpatches.html @@ -258,6 +258,9 @@ your email administrator for this.)

  • Make changes and update your branch based on feedback +
  • After an update, for the feedback you handled, close the + feedback discussion with the "Resolve Discussion" button. This way + the reviewers know which feedback got handled and which didn't.
  • Old, stale MR may be closed, but you can reopen it if you still want to pursue the changes
  • You should periodically check to see if your MR needs to be -- 2.7.4