From 1682161355d2ab57bfb291ab2eae6059a3d8b234 Mon Sep 17 00:00:00 2001 From: =?utf8?q?St=C3=A9phane=20Cerveau?= Date: Mon, 8 Mar 2021 10:44:42 +0100 Subject: [PATCH] alsa: remove useless ret test Use GST_ELEMENT_REGISTER_DEFINE_CUSTOM instead of GST_ELEMENT_REGISTER_DEFINE_WITH_CODE if a specific init needs to be tested before registering the element. Part-of: --- ext/alsa/gstalsamidisrc.c | 2 +- ext/alsa/gstalsasink.c | 2 +- ext/alsa/gstalsasrc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ext/alsa/gstalsamidisrc.c b/ext/alsa/gstalsamidisrc.c index c82ca37..96d4207 100644 --- a/ext/alsa/gstalsamidisrc.c +++ b/ext/alsa/gstalsamidisrc.c @@ -307,7 +307,7 @@ enum G_DEFINE_TYPE_WITH_CODE (GstAlsaMidiSrc, gst_alsa_midi_src, GST_TYPE_PUSH_SRC, _do_init); #define _do_element_init \ - ret |= alsa_element_init (plugin); + alsa_element_init (plugin); GST_ELEMENT_REGISTER_DEFINE_WITH_CODE (alsamidisrc, "alsamidisrc", GST_RANK_PRIMARY, GST_TYPE_ALSA_MIDI_SRC, _do_element_init); diff --git a/ext/alsa/gstalsasink.c b/ext/alsa/gstalsasink.c index 15f1b2b..f48dd71 100644 --- a/ext/alsa/gstalsasink.c +++ b/ext/alsa/gstalsasink.c @@ -74,7 +74,7 @@ enum }; #define _do_init \ - ret |= alsa_element_init (plugin); + alsa_element_init (plugin); #define gst_alsasink_parent_class parent_class G_DEFINE_TYPE (GstAlsaSink, gst_alsasink, GST_TYPE_AUDIO_SINK); GST_ELEMENT_REGISTER_DEFINE_WITH_CODE (alsasink, "alsasink", GST_RANK_PRIMARY, diff --git a/ext/alsa/gstalsasrc.c b/ext/alsa/gstalsasrc.c index 47d437b..431b744 100644 --- a/ext/alsa/gstalsasrc.c +++ b/ext/alsa/gstalsasrc.c @@ -72,7 +72,7 @@ enum #define gst_alsasrc_parent_class parent_class G_DEFINE_TYPE (GstAlsaSrc, gst_alsasrc, GST_TYPE_AUDIO_SRC); #define _do_init \ - ret |= alsa_element_init (plugin); + alsa_element_init (plugin); GST_ELEMENT_REGISTER_DEFINE_WITH_CODE (alsasrc, "alsasrc", GST_RANK_PRIMARY, GST_TYPE_ALSA_SRC, _do_init); -- 2.7.4