From 15c23d01fc2bf8affff0b616418f757364fc8f5b Mon Sep 17 00:00:00 2001 From: Tobin Ehlis Date: Mon, 19 Oct 2015 12:09:13 -0600 Subject: [PATCH] layers: Comment in DrawState for missing validation of DescriptorPool size limit --- layers/draw_state.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/layers/draw_state.cpp b/layers/draw_state.cpp index 4797a66..1673931 100755 --- a/layers/draw_state.cpp +++ b/layers/draw_state.cpp @@ -1911,6 +1911,9 @@ VK_LAYER_EXPORT VkResult VKAPI vkAllocDescriptorSets(VkDevice device, VkDescript return VK_ERROR_VALIDATION_FAILED; } else { memset(pNewNode, 0, sizeof(SET_NODE)); + // TODO : Pool should store a total count of each type of Descriptor available + // When descriptors are allocated, decrement the count and validate here + // that the count doesn't go below 0. One reset/free need to bump count back up. // Insert set at head of Set LL for this pool pNewNode->pNext = pPoolNode->pSets; pPoolNode->pSets = pNewNode; -- 2.7.4