From 15b2575b05e4eb25c12f398d5a426fc021736df9 Mon Sep 17 00:00:00 2001 From: Xiangyin Ma Date: Wed, 27 Apr 2016 15:59:51 +0100 Subject: [PATCH] Fix the buffer overflow issue in nanosvg Change-Id: I8d0f25c48bf1d5d307d7642b249e3baebcf63d41 --- dali-toolkit/internal/controls/renderers/svg/nanosvg/nanosvg.cc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/dali-toolkit/internal/controls/renderers/svg/nanosvg/nanosvg.cc b/dali-toolkit/internal/controls/renderers/svg/nanosvg/nanosvg.cc index 820e619..e52cb15 100644 --- a/dali-toolkit/internal/controls/renderers/svg/nanosvg/nanosvg.cc +++ b/dali-toolkit/internal/controls/renderers/svg/nanosvg/nanosvg.cc @@ -1244,7 +1244,12 @@ static NSVGcoordinate nsvg__parseCoordinateRaw(const char* str) { NSVGcoordinate coord = {0, NSVG_UNITS_USER}; char units[32]=""; - sscanf(str, "%f%s", &coord.value, units); + + /** + * In the original file, the formatted data reading did not specify the string with width limitation. + * To prevent the possible overflow, we replace '%s' with '%32s' here. + */ + sscanf(str, "%f%32s", &coord.value, units); coord.units = nsvg__parseUnits(units); return coord; } -- 2.7.4