From 15840e30dc264df3562eb606348c331f134fa982 Mon Sep 17 00:00:00 2001 From: Michael Suo Date: Sun, 24 Feb 2019 23:00:10 -0800 Subject: [PATCH] add pointer to windows FAQ in contributing.md (#17450) Summary: " ProTip! Great commit summaries contain fewer than 50 characters. Place extra information in the extended description." lol Pull Request resolved: https://github.com/pytorch/pytorch/pull/17450 Differential Revision: D14206500 Pulled By: suo fbshipit-source-id: af7ffe299f8c8f04fa8e720847a1f6d576ebafc1 --- CONTRIBUTING.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4e7749c..3a29518 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -335,6 +335,9 @@ Hope this helps, and thanks for considering to contribute. ## Windows development tips +For building from source on Windows, consult +[our documentation](https://pytorch.org/docs/stable/notes/windows.html) on it. + Occasionally, you will write a patch which works on Linux, but fails CI on Windows. There are a few aspects in which MSVC (the Windows compiler toolchain we use) is stricter than Linux, which are worth keeping in mind when fixing these problems. -- 2.7.4