From 153818f09f1653d42a5c0404c94cacc519218b9e Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Mon, 1 Oct 2012 11:47:46 +0200 Subject: [PATCH] pwg: final cleanups for 1.0 --- docs/pwg/appendix-checklist.xml | 18 ++++-------------- docs/pwg/appendix-porting.xml | 8 ++++++++ docs/pwg/other-manager.xml | 4 +++- docs/pwg/other-ntoone.xml | 2 +- 4 files changed, 16 insertions(+), 16 deletions(-) diff --git a/docs/pwg/appendix-checklist.xml b/docs/pwg/appendix-checklist.xml index 503031f..336d3da 100644 --- a/docs/pwg/appendix-checklist.xml +++ b/docs/pwg/appendix-checklist.xml @@ -133,7 +133,7 @@ gst_pad_set_event_func (myelement->srcpad, Elements should make sure they forward events they do not - handle with gst_pad_event_default (pad, event) instead of + handle with gst_pad_event_default (pad, parent, event) instead of just dropping them. Events should never be dropped unless specifically intended. @@ -141,20 +141,10 @@ gst_pad_set_event_func (myelement->srcpad, Elements should make sure they forward queries they do not - handle with gst_pad_query_default (pad, query) instead of + handle with gst_pad_query_default (pad, parent, query) instead of just dropping them. - - - Elements should use gst_pad_get_parent() in event and query - functions, so that they hold a reference to the element while they - are operating. Note that gst_pad_get_parent() increases the - reference count of the element, so you must be very careful to call - gst_object_unref (element) before returning from your query or - event function, otherwise you will leak memory. - - @@ -168,8 +158,8 @@ gst_pad_set_event_func (myelement->srcpad, tool to show that your element is finished. Applications such as Rhythmbox and Totem (for GNOME) or AmaroK (for KDE) are. gst-launch will not - test various things such as proper clean-up on reset, interrupt - event handling, querying and so on. + test various things such as proper clean-up on reset, event + handling, querying and so on. diff --git a/docs/pwg/appendix-porting.xml b/docs/pwg/appendix-porting.xml index d7a3ec4..ab457a8 100644 --- a/docs/pwg/appendix-porting.xml +++ b/docs/pwg/appendix-porting.xml @@ -186,3 +186,11 @@ + + + Porting 0.10 plug-ins to 1.0 + + You can find the list of changes in the + Porting to 1.0 document. + + diff --git a/docs/pwg/other-manager.xml b/docs/pwg/other-manager.xml index ebd1ace..5338114 100644 --- a/docs/pwg/other-manager.xml +++ b/docs/pwg/other-manager.xml @@ -30,7 +30,9 @@ To embed an element, or a series of elements, into something that - looks and works like a simple element to the outside world. + looks and works like a simple element to the outside world. This + is particular handy for implementing sources and sink elements with + multiple pads. diff --git a/docs/pwg/other-ntoone.xml b/docs/pwg/other-ntoone.xml index d9b75b8..9efcff6 100644 --- a/docs/pwg/other-ntoone.xml +++ b/docs/pwg/other-ntoone.xml @@ -9,7 +9,7 @@ and the N-to-1 element synchronizes those streams by expected-timestamp-based logic. This means it lets all streams wait except for the one that provides the earliest next-expected timestamp. - When that stream has passwed one buffer, the next + When that stream has passed one buffer, the next earliest-expected-timestamp is calculated, and we start back where we were, until all streams have reached EOS. There is a helper base class, called GstCollectPads, that will help you to do -- 2.7.4