From 15076f923238d606adc8a20d0de2e738f0dcf829 Mon Sep 17 00:00:00 2001 From: Andrey Kamaev Date: Mon, 22 Oct 2012 18:39:56 +0400 Subject: [PATCH] Fix implementation of PCA overload with retained variance parameter --- modules/core/src/matmul.cpp | 4 ++-- modules/core/test/test_mat.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/core/src/matmul.cpp b/modules/core/src/matmul.cpp index af8c575..9b38685 100644 --- a/modules/core/src/matmul.cpp +++ b/modules/core/src/matmul.cpp @@ -2813,7 +2813,7 @@ PCA::PCA(InputArray data, InputArray _mean, int flags, int maxComponents) PCA::PCA(InputArray data, InputArray _mean, int flags, double retainedVariance) { - operator()(data, _mean, flags, retainedVariance); + computeVar(data, _mean, flags, retainedVariance); } PCA& PCA::operator()(InputArray _data, InputArray __mean, int flags, int maxComponents) @@ -3077,7 +3077,7 @@ void cv::PCAComputeVar(InputArray data, InputOutputArray mean, OutputArray eigenvectors, double retainedVariance) { PCA pca; - pca(data, mean, 0, retainedVariance); + pca.computeVar(data, mean, 0, retainedVariance); pca.mean.copyTo(mean); pca.eigenvectors.copyTo(eigenvectors); } diff --git a/modules/core/test/test_mat.cpp b/modules/core/test/test_mat.cpp index 8c72789..514b587 100644 --- a/modules/core/test/test_mat.cpp +++ b/modules/core/test/test_mat.cpp @@ -426,7 +426,7 @@ protected: } // 3. check C++ PCA w/retainedVariance - cPCA( rPoints.t(), Mat(), CV_PCA_DATA_AS_COL, retainedVariance ); + cPCA.computeVar( rPoints.t(), Mat(), CV_PCA_DATA_AS_COL, retainedVariance ); diffPrjEps = 1, diffBackPrjEps = 1; Mat rvPrjTestPoints = cPCA.project(rTestPoints.t()); -- 2.7.4