From 14ce3192392edde90aa444c153eacede6c1ba5c5 Mon Sep 17 00:00:00 2001 From: Gary Benson Date: Wed, 6 Aug 2014 14:43:17 +0100 Subject: [PATCH] Convert fatal to perror_with_name in IPA code This commit converts four calls to fatal into calls to perror_with_name. perror_with_name calls error, which in IPA terminates with exit (1) rather than longjmp, so there is no functional change here. gdb/gdbserver/ChangeLog: * tracepoint.c (gdb_agent_init): Replace fatal with perror_with_name. (initialize_tracepoint): Likewise. --- gdb/gdbserver/ChangeLog | 6 ++++++ gdb/gdbserver/tracepoint.c | 10 ++++------ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index dd89aab..9400b8a 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,5 +1,11 @@ 2014-08-28 Gary Benson + * tracepoint.c (gdb_agent_init): Replace fatal with + perror_with_name. + (initialize_tracepoint): Likewise. + +2014-08-28 Gary Benson + * remote-utils.c (remote_prepare): Replace fatal with error. 2014-08-28 Gary Benson diff --git a/gdb/gdbserver/tracepoint.c b/gdb/gdbserver/tracepoint.c index a9a4062..2e83d71 100644 --- a/gdb/gdbserver/tracepoint.c +++ b/gdb/gdbserver/tracepoint.c @@ -7290,7 +7290,7 @@ gdb_agent_init (void) sigfillset (&new_mask); res = pthread_sigmask (SIG_SETMASK, &new_mask, &orig_mask); if (res) - fatal ("pthread_sigmask (1) failed: %s", strerror (res)); + perror_with_name ("pthread_sigmask (1)"); res = pthread_create (&thread, NULL, @@ -7299,7 +7299,7 @@ gdb_agent_init (void) res = pthread_sigmask (SIG_SETMASK, &orig_mask, NULL); if (res) - fatal ("pthread_sigmask (2) failed: %s", strerror (res)); + perror_with_name ("pthread_sigmask (2)"); while (helper_thread_id == 0) usleep (1); @@ -7380,7 +7380,7 @@ initialize_tracepoint (void) pagesize = sysconf (_SC_PAGE_SIZE); if (pagesize == -1) - fatal ("sysconf"); + perror_with_name ("sysconf"); gdb_tp_heap_buffer = xmalloc (5 * 1024 * 1024); @@ -7399,9 +7399,7 @@ initialize_tracepoint (void) } if (addr == 0) - fatal ("\ -initialize_tracepoint: mmap'ing jump pad buffer failed with %s", - strerror (errno)); + perror_with_name ("mmap"); gdb_jump_pad_buffer_end = gdb_jump_pad_buffer + pagesize * SCRATCH_BUFFER_NPAGES; } -- 2.7.4