From 14a8039c15d1ef9bc6198da839a60cb7f1e610f5 Mon Sep 17 00:00:00 2001 From: "allu.k" Date: Mon, 14 Sep 2020 12:59:17 +0530 Subject: [PATCH] Resolved SVACE Issues Change-Id: I062bcace1d857bcbd9166ad014438b01a544bf17 --- src/apps_db.c | 10 ++++++++++ src/apps_view.c | 2 +- src/cluster_db.c | 8 ++++++++ 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/src/apps_db.c b/src/apps_db.c index 6718fb5..cb4c053 100644 --- a/src/apps_db.c +++ b/src/apps_db.c @@ -266,6 +266,8 @@ bool apps_db_update(app_data_t *item) ret = sqlite3_step(stmt); if (SQLITE_DONE != ret) { __E("sqlite error : [%s,%s]", UPDATE_APPS_DB_TABLE, sqlite3_errmsg(apps_db)); + sqlite3_finalize(stmt); + __apps_db_close(); return false; } @@ -304,6 +306,8 @@ bool apps_db_insert(app_data_t *item) ret = sqlite3_step(stmt); if (SQLITE_DONE != ret) { __E("sqlite error : [%s,%s]", INSERT_APPS_DB_TABLE, sqlite3_errmsg(apps_db)); + sqlite3_finalize(stmt); + __apps_db_close(); return false; } sqlite3_finalize(stmt); @@ -331,6 +335,8 @@ bool apps_db_delete(app_data_t *item) ret = sqlite3_step(stmt); if (SQLITE_DONE != ret) { __E("sqlite error : [%s,%s]", query, sqlite3_errmsg(apps_db)); + sqlite3_finalize(stmt); + __apps_db_close(); return false; } @@ -359,6 +365,8 @@ bool apps_db_delete_by_app_id(const char* app_id) ret = sqlite3_step(stmt); if (SQLITE_DONE != ret) { __E("sqlite error : [%s,%s]", query, sqlite3_errmsg(apps_db)); + sqlite3_finalize(stmt); + __apps_db_close(); return false; } sqlite3_finalize(stmt); @@ -386,6 +394,8 @@ bool apps_db_delete_by_pkg_id(const char* pkg_id) ret = sqlite3_step(stmt); if (SQLITE_DONE != ret) { __E("sqlite error : [%s,%s]", query, sqlite3_errmsg(apps_db)); + sqlite3_finalize(stmt); + __apps_db_close(); return false; } sqlite3_finalize(stmt); diff --git a/src/apps_view.c b/src/apps_view.c index b0a982b..c70d9b2 100644 --- a/src/apps_view.c +++ b/src/apps_view.c @@ -326,7 +326,7 @@ void apps_view_folder_reroder(void) return; } msg->count = 2; - msg->val[0] = item_count / APPS_FOLDER_COL; + msg->val[0] = (int)(item_count / APPS_FOLDER_COL); msg->val[1] = item_count % APPS_FOLDER_COL; if (apps_view_get_state() != VIEW_STATE_CHOOSER) { diff --git a/src/cluster_db.c b/src/cluster_db.c index 7b83422..5ad2de0 100755 --- a/src/cluster_db.c +++ b/src/cluster_db.c @@ -117,9 +117,11 @@ bool move_external_cluster_db(void) if (ret != SQLITE_OK) { __E("sqlite error : QUERY_CLUSTER_DB : %s", sqlite3_errmsg(cluster_db)); __E("Removing external cluster db"); + sqlite3_finalize(stmt); ecore_file_remove(db_path); return false; } + sqlite3_finalize(stmt); return true; } @@ -263,6 +265,8 @@ bool cluster_db_update(widget_data_t *item) ret = sqlite3_step(stmt); if (SQLITE_DONE != ret) { __E("sqlite error : [%s,%s]", UPDATE_CLUSTER_DB_TABLE, sqlite3_errmsg(cluster_db)); + sqlite3_finalize(stmt); + __cluster_db_close(); return false; } @@ -297,6 +301,8 @@ bool cluster_db_insert(widget_data_t *item) ret = sqlite3_step(stmt); if (SQLITE_DONE != ret) { __E("sqlite error : [%s,%s]", INSERT_CLUSTER_DB_TABLE, sqlite3_errmsg(cluster_db)); + sqlite3_finalize(stmt); + __cluster_db_close(); return false; } @@ -327,6 +333,8 @@ bool cluster_db_delete(widget_data_t *item) ret = sqlite3_step(stmt); if (SQLITE_DONE != ret) { __E("sqlite error : [%s,%s]", query, sqlite3_errmsg(cluster_db)); + sqlite3_finalize(stmt); + __cluster_db_close(); return false; } sqlite3_finalize(stmt); -- 2.7.4