From 1461c1d55c1a25a66670d067ee037862c4dcd5ea Mon Sep 17 00:00:00 2001 From: =?utf8?q?V=C3=ADctor=20Manuel=20J=C3=A1quez=20Leal?= Date: Wed, 29 Mar 2023 12:44:00 +0200 Subject: [PATCH] tests: vkimage: add VK_IMAGE_USAGE_SAMPLED_BIT usage bit Running tests with Vulkan Validation enabled show an error on vkimage tests: Code 0 : Validation Error: [ VUID-VkImageViewCreateInfo-image-04441 ] Object 0: VK_NULL_HANDLE, type = VK_OBJECT_TYPE_COMMAND_BUFFER; Object 1: handle = 0x50000000005, type = VK_OBJECT_TYPE_IMAGE; | MessageID = 0xb75da543 | Invalid usage flag for VkImage 0x50000000005[] used by vkCreateImageView(). In this case, VkImage should have VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_STORAGE_BIT | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT | VK_IMAGE_USAGE_FRAGMENT_SHADING_RATE_ATTACHMENT_BIT_KHR | VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT | VK_IMAGE_USAGE_VIDEO_DECODE_DST_BIT_KHR | VK_IMAGE_USAGE_VIDEO_DECODE_DPB_BIT_KHR | VK_IMAGE_USAGE_VIDEO_ENCODE_SRC_BIT_KHR | VK_IMAGE_USAGE_VIDEO_ENCODE_DPB_BIT_KHR | VK_IMAGE_USAGE_SAMPLE_WEIGHT_BIT_QCOM | VK_IMAGE_USAGE_SAMPLE_BLOCK_MATCH_BIT_QCOM set during creation. The Vulkan spec states: image must have been created with a usage value containing at least one of the usages defined in the valid image usage list for image views This patch adds VK_IMAGE_USAGE_SAMPLED_BIT to the usage bits in test. Part-of: --- subprojects/gst-plugins-bad/tests/check/libs/vkimage.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/subprojects/gst-plugins-bad/tests/check/libs/vkimage.c b/subprojects/gst-plugins-bad/tests/check/libs/vkimage.c index 6ef279b..f3c13fe 100644 --- a/subprojects/gst-plugins-bad/tests/check/libs/vkimage.c +++ b/subprojects/gst-plugins-bad/tests/check/libs/vkimage.c @@ -66,7 +66,8 @@ create_image_mem (GstVideoInfo * v_info) vk_format = gst_vulkan_format_from_video_info (v_info, 0); - usage = VK_IMAGE_USAGE_TRANSFER_SRC_BIT | VK_IMAGE_USAGE_TRANSFER_DST_BIT; + usage = VK_IMAGE_USAGE_TRANSFER_SRC_BIT | VK_IMAGE_USAGE_TRANSFER_DST_BIT + | VK_IMAGE_USAGE_SAMPLED_BIT; mem = gst_vulkan_image_memory_alloc (device, vk_format, GST_VIDEO_INFO_COMP_WIDTH (v_info, 0), -- 2.7.4