From 1432c908ac11f77e47eba950586b85775ab78635 Mon Sep 17 00:00:00 2001 From: Junghyun Yeon Date: Mon, 3 Aug 2020 14:46:17 +0900 Subject: [PATCH] Fix static analysis issue Add checking routine to each variable not exceed buffer length Change-Id: I4705d4d524b6414a15a3ee54195d8787767e097e Signed-off-by: Junghyun Yeon --- installer/pkgmgr_installer_signal_agent.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/installer/pkgmgr_installer_signal_agent.c b/installer/pkgmgr_installer_signal_agent.c index 2b5ae47..ca70733 100644 --- a/installer/pkgmgr_installer_signal_agent.c +++ b/installer/pkgmgr_installer_signal_agent.c @@ -225,7 +225,8 @@ static gboolean __handle_signal(gint fd, GIOCondition cond, gpointer user_data) memcpy(&type_len, buf, sizeof(size_t)); memcpy(&data_len, buf + sizeof(size_t), sizeof(gsize)); - if ((type_len + data_len) > BUFMAX) { + if (type_len > BUFMAX || data_len > BUFMAX || + (type_len + data_len) > BUFMAX) { LOGE("received size is too large: %zu %zu", type_len, data_len); close(clifd); return FALSE; -- 2.34.1