From 13ecee2146355ef5c516378b712e459d5ebab934 Mon Sep 17 00:00:00 2001 From: rakdver Date: Mon, 31 Mar 2008 14:19:52 +0000 Subject: [PATCH] PR rtl-optimization/35729 * loop-invariant.c (check_maybe_invariant): Disallow volatile memory references. * gcc.dg/pr35729.c: New test. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@133755 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/ChangeLog | 6 ++++++ gcc/loop-invariant.c | 2 +- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.dg/pr35729.c | 15 +++++++++++++++ 4 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/pr35729.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 0a426b1..a78eae8 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2008-03-31 Zdenek Dvorak + + PR rtl-optimization/35729 + * loop-invariant.c (check_maybe_invariant): Disallow volatile memory + references. + 2008-03-31 H.J. Lu PR target/32000 diff --git a/gcc/loop-invariant.c b/gcc/loop-invariant.c index ba1f288..64c16a9 100644 --- a/gcc/loop-invariant.c +++ b/gcc/loop-invariant.c @@ -206,7 +206,7 @@ check_maybe_invariant (rtx x) /* Just handle the most trivial case where we load from an unchanging location (most importantly, pic tables). */ - if (MEM_READONLY_P (x)) + if (MEM_READONLY_P (x) && !MEM_VOLATILE_P (x)) break; return false; diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 3423800..6c208d9 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2008-03-31 Zdenek Dvorak + + PR rtl-optimization/35729 + * gcc.dg/pr35729.c: New test. + 2008-03-31 H.J. Lu PR target/32000 diff --git a/gcc/testsuite/gcc.dg/pr35729.c b/gcc/testsuite/gcc.dg/pr35729.c new file mode 100644 index 0000000..3ed40f4 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr35729.c @@ -0,0 +1,15 @@ +/* { dg-do compile } */ +/* { dg-options "-Os -fdump-rtl-loop2_invariant" } */ + +const volatile int g_361 = 3L; +volatile int g_2 = 0L; +void func_1 (void) +{ + for (g_2 = 0; g_2 > 10; g_2++) + { + int l_357 = g_361; + } +} + +/* { dg-final { scan-rtl-dump-times "Decided to move invariant" 0 "loop2_invariant" } } */ +/* { dg-final { cleanup-rtl-dump "loop2_invariant" } } */ -- 2.7.4