From 13bccac5a7d930c809927e69ba7305330fb8a9be Mon Sep 17 00:00:00 2001 From: Erik Faye-Lund Date: Wed, 16 Nov 2022 12:55:26 +0100 Subject: [PATCH] zink: update textureCompressionBC requirement The mesa state-tracker can now emulate all formats indicated by this feature-flag, so we don't require this for OpenGL 4.2 any more. It's however a good idea to support for power-usage and performance reasons, saving on memory bandwidth. So let's move it to the gl46_optimal block instead. Fixes: e4ff42684b9 ("mesa/st: enable bptc extension with fallback") Fixes: 2ea481b2f0a ("Zink: add Zink profiles file") Part-of: --- docs/drivers/zink.rst | 1 - src/gallium/drivers/zink/VP_ZINK_requirements.json | 6 ++++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/drivers/zink.rst b/docs/drivers/zink.rst index 4959ef5..2f091ef 100644 --- a/docs/drivers/zink.rst +++ b/docs/drivers/zink.rst @@ -175,7 +175,6 @@ supported: * ``shaderStorageImageWriteWithoutFormat`` * ``vertexPipelineStoresAndAtomics`` * ``fragmentStoresAndAtomics`` - * ``textureCompressionBC`` * For Vulkan 1.2 and above: diff --git a/src/gallium/drivers/zink/VP_ZINK_requirements.json b/src/gallium/drivers/zink/VP_ZINK_requirements.json index 51bdb52a..f42f4c8 100644 --- a/src/gallium/drivers/zink/VP_ZINK_requirements.json +++ b/src/gallium/drivers/zink/VP_ZINK_requirements.json @@ -169,8 +169,7 @@ "shaderStorageImageExtendedFormats": true, "shaderStorageImageWriteWithoutFormat": true, "vertexPipelineStoresAndAtomics": true, - "fragmentStoresAndAtomics": true, - "textureCompressionBC": true + "fragmentStoresAndAtomics": true } } }, @@ -314,6 +313,9 @@ "VK_EXT_non_seamless_cube_map": 1 }, "features": { + "VkPhysicalDeviceFeatures": { + "textureCompressionBC": true + }, "VkPhysicalDeviceExtendedDynamicStateFeaturesEXT": { "extendedDynamicState": true }, -- 2.7.4