From 13ac8d2c29bd346711448e3d6630d231e46fb70d Mon Sep 17 00:00:00 2001 From: Jan Kratochvil Date: Mon, 19 Dec 2011 13:37:34 +0000 Subject: [PATCH] gdb/doc/ * gdbint.texinfo (Testsuite): Describe KFAIL and XFAIL in Writing tests. gdb/testsuite/ * gdb.cp/ptype-cv-cp.exp (ptype v_volatile_const_my_int): Replace KFAIL by XFAIL. * gdb.cp/static-method.exp (info addr A::func()) (list static-method.cc:xxx::(anonymous namespace)::A::func) (list 'static-method.cc:xxx::(anonymous namespace)::A::func') (list 'static-method.cc':'xxx::(anonymous namespace)::A::func') (list static-method.cc:'xxx::(anonymous namespace)::A::func'): Likewise. * gdb.cp/temargs.exp (test value of F in k2_m, test type of F in k3_m) (test value of F in k3_m): Likewise. * gdb.python/py-type.exp (python print ttype.template_argument(2)): Likewise. --- gdb/doc/ChangeLog | 5 +++++ gdb/doc/gdbint.texinfo | 39 ++++++++++++++++++++++++++++++++++ gdb/testsuite/ChangeLog | 14 ++++++++++++ gdb/testsuite/gdb.cp/ptype-cv-cp.exp | 2 +- gdb/testsuite/gdb.cp/static-method.exp | 11 +++++----- gdb/testsuite/gdb.cp/temargs.exp | 6 +++--- gdb/testsuite/gdb.python/py-type.exp | 2 +- 7 files changed, 69 insertions(+), 10 deletions(-) diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index 8451302..0632d09 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,3 +1,8 @@ +2011-12-19 Jan Kratochvil + + * gdbint.texinfo (Testsuite): Describe KFAIL and XFAIL in Writing + tests. + 2011-12-16 Doug Evans * gdb.texinfo (Server): Document -/stdio argument to gdbserver. diff --git a/gdb/doc/gdbint.texinfo b/gdb/doc/gdbint.texinfo index 20791b4..cd4d492 100644 --- a/gdb/doc/gdbint.texinfo +++ b/gdb/doc/gdbint.texinfo @@ -7846,6 +7846,45 @@ instance, some @value{GDBN} bugs involving the display of source lines would never manifest themselves if the programs used GNU coding style uniformly. +Some testcase results need more detailed explanation: + +@table @code +@item KFAIL +Known problem of @value{GDBN} itself. You must specify the @value{GDBN} bug +report number like in these sample tests: +@smallexample +kfail "gdb/13392" "continue to marker 2" +@end smallexample +or +@smallexample +setup_kfail gdb/13392 "*-*-*" +kfail "continue to marker 2" +@end smallexample + +@item XFAIL +Known problem of environment. This typically includes @value{NGCC} but it +includes also many other system components which cannot be fixed in the +@value{GDBN} project. Sample test with sanity check not knowing the specific +cause of the problem: +@smallexample +# On x86_64 it is commonly about 4MB. +if @{$stub_size > 25000000@} @{ + xfail "stub size $stub_size is too large" + return +@} +@end smallexample + +You should provide bug report number for the failing component of the +environment, if such bug report is available: +@smallexample +if @{[test_compiler_info @{gcc-[0-3]-*@}] + || [test_compiler_info @{gcc-4-[0-5]-*@}]@} @{ + setup_xfail "gcc/46955" *-*-* +@} +gdb_test "python print ttype.template_argument(2)" "&C::c" +@end smallexample +@end table + @node Hints @chapter Hints diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index fe12c18..f618349 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,19 @@ 2011-12-19 Jan Kratochvil + * gdb.cp/ptype-cv-cp.exp (ptype v_volatile_const_my_int): Replace KFAIL + by XFAIL. + * gdb.cp/static-method.exp (info addr A::func()) + (list static-method.cc:xxx::(anonymous namespace)::A::func) + (list 'static-method.cc:xxx::(anonymous namespace)::A::func') + (list 'static-method.cc':'xxx::(anonymous namespace)::A::func') + (list static-method.cc:'xxx::(anonymous namespace)::A::func'): Likewise. + * gdb.cp/temargs.exp (test value of F in k2_m, test type of F in k3_m) + (test value of F in k3_m): Likewise. + * gdb.python/py-type.exp (python print ttype.template_argument(2)): + Likewise. + +2011-12-19 Jan Kratochvil + * gdb.threads/attach-stopped.exp (continue (*: attach2 continue)) (*: attach2 stop interrupt, *: attach2, exit leaves process sleeping): Remove. diff --git a/gdb/testsuite/gdb.cp/ptype-cv-cp.exp b/gdb/testsuite/gdb.cp/ptype-cv-cp.exp index 254f889..21b4365 100644 --- a/gdb/testsuite/gdb.cp/ptype-cv-cp.exp +++ b/gdb/testsuite/gdb.cp/ptype-cv-cp.exp @@ -37,5 +37,5 @@ gdb_test "whatis v_const_volatile_my_int" "type = const_volatile_my_int" gdb_test "ptype v_const_volatile_my_int" "type = const volatile int" gdb_test "whatis v_volatile_const_my_int" "type = volatile_const_my_int" -setup_kfail "gcc/45997" *-*-* +setup_xfail "gcc/45997" "*-*-*" gdb_test "ptype v_volatile_const_my_int" "type = const volatile int" diff --git a/gdb/testsuite/gdb.cp/static-method.exp b/gdb/testsuite/gdb.cp/static-method.exp index 21e3747..79b53ab 100644 --- a/gdb/testsuite/gdb.cp/static-method.exp +++ b/gdb/testsuite/gdb.cp/static-method.exp @@ -60,7 +60,8 @@ gdb_test_multiple $test $test { pass $test } -re "Symbol \"A::func\\(\\)\" is a function at address .*\r\n$gdb_prompt $" { - kfail gcc/45682 $test + setup_xfail gcc/45682 "*-*-*" + fail $test set have_gcc_45682_fixed 0 } } @@ -87,22 +88,22 @@ foreach test $methods { # with the filename pre-pended. if {[string compare $test "xxx::${ans}::A::func"] == 0 && !$have_gcc_45682_fixed} { - setup_kfail gcc/45682 "*-*-*" + setup_xfail gcc/45682 "*-*-*" } gdb_test "list ${srcfile}:$test" $result if {[string compare $test "xxx::${ans}::A::func"] == 0 && !$have_gcc_45682_fixed} { - setup_kfail gcc/45682 "*-*-*" + setup_xfail gcc/45682 "*-*-*" } gdb_test "list '${srcfile}:$test'" $result if {[string compare $test "xxx::${ans}::A::func"] == 0 && !$have_gcc_45682_fixed} { - setup_kfail gcc/45682 "*-*-*" + setup_xfail gcc/45682 "*-*-*" } gdb_test "list '${srcfile}':'$test'" $result if {[string compare $test "xxx::${ans}::A::func"] == 0 && !$have_gcc_45682_fixed} { - setup_kfail gcc/45682 "*-*-*" + setup_xfail gcc/45682 "*-*-*" } gdb_test "list ${srcfile}:'$test'" $result diff --git a/gdb/testsuite/gdb.cp/temargs.exp b/gdb/testsuite/gdb.cp/temargs.exp index d094c5a..f97b5ab 100644 --- a/gdb/testsuite/gdb.cp/temargs.exp +++ b/gdb/testsuite/gdb.cp/temargs.exp @@ -176,7 +176,7 @@ if $have_older_template_gcc { setup_xfail "*-*-*" } gdb_test "ptype F" "type = void \\\(S::\\\*\\\)\\\(S \\\* const\\\)" \ "test type of F in k2_m" -setup_kfail gcc/49366 "*-*-*" +setup_xfail gcc/49366 "*-*-*" gdb_test "print F" "&S::somefunc" "test value of F in k2_m" # @@ -189,10 +189,10 @@ gdb_test "print F" "&S::somefunc" "test value of F in k2_m" gdb_continue_to_breakpoint "continue to sixth breakpoint for temargs" if $have_older_template_gcc { setup_xfail "*-*-*" -} else { setup_kfail gcc/49546 "*-*-*" } +} else { setup_xfail gcc/49546 "*-*-*" } gdb_test "ptype F" {type = void \(\*\)\(int\)} "test type of F in k3_m" if $have_older_template_gcc { setup_xfail "*-*-*" -} else { setup_kfail gcc/49546 "*-*-*" } +} else { setup_xfail gcc/49546 "*-*-*" } gdb_test "print F" { = \(void \(\*\)\(int\)\) 0x[0-9a-f]+ } \ "test value of F in k3_m" diff --git a/gdb/testsuite/gdb.python/py-type.exp b/gdb/testsuite/gdb.python/py-type.exp index 056f4e1..b5e6ff9 100644 --- a/gdb/testsuite/gdb.python/py-type.exp +++ b/gdb/testsuite/gdb.python/py-type.exp @@ -193,7 +193,7 @@ proc test_template {} { gdb_test "python print isinstance(ttype.template_argument(1), gdb.Value)" \ "True" - setup_kfail "gcc/41736" *-*-* + setup_xfail "gcc/41736" *-*-* gdb_test "python print ttype.template_argument(2)" "&C::c" } -- 2.7.4