From 12a4bf012752a388fc8ec81026984a56c203dfb9 Mon Sep 17 00:00:00 2001 From: vitek-karas Date: Mon, 10 Sep 2018 10:39:28 -0700 Subject: [PATCH] Rename bindingId to activityId To match EventSource terminology as the meaning of the parameter is exactly that. Commit migrated from https://github.com/dotnet/core-setup/commit/726b1c3ee0174dd7e478d6580a01c60d38cc7a8e --- docs/installer/design-docs/host-tracing.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/installer/design-docs/host-tracing.md b/docs/installer/design-docs/host-tracing.md index 1990c24..a057520 100644 --- a/docs/installer/design-docs/host-tracing.md +++ b/docs/installer/design-docs/host-tracing.md @@ -55,16 +55,16 @@ The trace listener interface looks like this: ``` C++ struct host_trace_listener { - void trace_verbose(const pal::char_t *message, const pal::char_t *bindingId); - void trace_info(const pal::char_t *message, const pal::char_t *bindingId); - void trace_warning(const pal::char_t *message, const pal::char_t *bindingId); - void trace_error(const pal::char_t *message, const pal::char_t *bindingId); + void trace_verbose(const pal::char_t *message, const pal::char_t *activityId); + void trace_info(const pal::char_t *message, const pal::char_t *activityId); + void trace_warning(const pal::char_t *message, const pal::char_t *activityId); + void trace_error(const pal::char_t *message, const pal::char_t *activityId); void flush(); } ``` The `message` parameter is a standard `NUL` terminated string and it's the message to trace with the respective verbosity level. -The `bidningId` parameter is a standard `NUL` terminated string. It's used to correlate traces for a given binding event. The content of the string is not yet defined, but the trace listeners should consider it opaque. Trace listeners should include this string in the trace of the message in some form. The parameter may be `NULL` in which case the trace doesn't really belong to any specific binding event. +The `activityId` parameter is a standard `NUL` terminated string. It's used to correlate traces for a given binding event. The content of the string is not yet defined, but the trace listeners should consider it opaque. Trace listeners should include this string in the trace of the message in some form. The parameter may be `NULL` in which case the trace doesn't really belong to any specific binding event. Methods on the trace listener interface can be called from any thread in the app, and should be able to handle multiple calls at the same time from different threads. -- 2.7.4