From 12a281d368e3ae115b2340c45f93b62e20759811 Mon Sep 17 00:00:00 2001 From: Reid Kleckner Date: Fri, 11 Sep 2020 17:43:49 -0700 Subject: [PATCH] [gn] Remove unneeded MC dep from llvm-tblgen Tablegen does not have link time dependencies on MC. Having llvm-tblgen depend on it causes it to be rebuilt in the gn build every time somebody touches any cpp file in llvm/lib/MC* or llvm/lib/DebugInfo/Codeview*. Touching tablegen invalidates most of the rest of the build, and re-running it takes a while. This is is annoying for me when swapping between branches that touch CodeView logic. This dep was added to LLVMBuild.txt back in 2018, and presumably it was carried over into the gn build. Differential Revision: https://reviews.llvm.org/D87553 --- llvm/utils/TableGen/LLVMBuild.txt | 2 +- llvm/utils/gn/secondary/llvm/utils/TableGen/BUILD.gn | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/llvm/utils/TableGen/LLVMBuild.txt b/llvm/utils/TableGen/LLVMBuild.txt index 5eec4e0..6293aa0 100644 --- a/llvm/utils/TableGen/LLVMBuild.txt +++ b/llvm/utils/TableGen/LLVMBuild.txt @@ -18,4 +18,4 @@ type = BuildTool name = tblgen parent = BuildTools -required_libraries = Support TableGen MC +required_libraries = Support TableGen diff --git a/llvm/utils/gn/secondary/llvm/utils/TableGen/BUILD.gn b/llvm/utils/gn/secondary/llvm/utils/TableGen/BUILD.gn index 4559926..bd1382d 100644 --- a/llvm/utils/gn/secondary/llvm/utils/TableGen/BUILD.gn +++ b/llvm/utils/gn/secondary/llvm/utils/TableGen/BUILD.gn @@ -1,7 +1,6 @@ executable("llvm-tblgen") { deps = [ "//llvm/include/llvm/Config:llvm-config", - "//llvm/lib/MC", "//llvm/lib/Support", "//llvm/lib/TableGen", "//llvm/utils/TableGen/GlobalISel", -- 2.7.4