From 125293f972def4b7793fe2a08321bc1d4780eff5 Mon Sep 17 00:00:00 2001 From: "hausmann@webkit.org" Date: Tue, 17 Apr 2012 07:47:28 +0000 Subject: [PATCH] [Plugins] delete ws_info regardless of window mode. https://bugs.webkit.org/show_bug.cgi?id=83004 Patch by Bang Kwang min on 2012-04-17 Reviewed by Simon Hausmann. m_npWindow.ws_info should be deleted even if plugin run as windowless mode to remove memory leak. Every plugin works well after this patch without any crash. Additionally, change casting syntax to C++ style. * plugins/PluginView.cpp: (WebCore::PluginView::stop): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114358 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Source/WebCore/ChangeLog | 14 ++++++++++++++ Source/WebCore/plugins/PluginView.cpp | 3 +-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog index 9b1e06a..46ef06c 100644 --- a/Source/WebCore/ChangeLog +++ b/Source/WebCore/ChangeLog @@ -1,3 +1,17 @@ +2012-04-17 Bang Kwang min + + [Plugins] delete ws_info regardless of window mode. + https://bugs.webkit.org/show_bug.cgi?id=83004 + + Reviewed by Simon Hausmann. + + m_npWindow.ws_info should be deleted even if plugin run as windowless mode to remove memory leak. + Every plugin works well after this patch without any crash. + Additionally, change casting syntax to C++ style. + + * plugins/PluginView.cpp: + (WebCore::PluginView::stop): + 2012-04-17 Kent Tamura Calendar Picker: Support RTL layout diff --git a/Source/WebCore/plugins/PluginView.cpp b/Source/WebCore/plugins/PluginView.cpp index 749f609..9a5ffa8 100644 --- a/Source/WebCore/plugins/PluginView.cpp +++ b/Source/WebCore/plugins/PluginView.cpp @@ -366,8 +366,7 @@ void PluginView::stop() } #ifdef XP_UNIX - if (m_isWindowed && m_npWindow.ws_info) - delete (NPSetWindowCallbackStruct *)m_npWindow.ws_info; + delete static_cast(m_npWindow.ws_info); m_npWindow.ws_info = 0; #endif -- 2.7.4