From 123aa04f7b3241d6e43de2d472c4a1cbdb250ac7 Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Thu, 28 Apr 2011 12:58:28 -0400 Subject: [PATCH] Fix possible but improbable overflow in hb_array_t --- src/hb-private.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hb-private.hh b/src/hb-private.hh index ce09d18..ca37084 100644 --- a/src/hb-private.hh +++ b/src/hb-private.hh @@ -297,7 +297,7 @@ struct hb_static_array_t { array = new_array; } } else { - bool overflows = new_allocated >= ((unsigned int) -1) / sizeof (Type); + bool overflows = (new_allocated < allocated) || (new_allocated >= ((unsigned int) -1) / sizeof (Type)); if (unlikely (overflows)) new_array = NULL; else -- 2.7.4