From 119d3d80cbb53ff601f5bf56affb464d3b5f55ea Mon Sep 17 00:00:00 2001 From: Nicolai Haehnle Date: Mon, 2 May 2016 17:37:01 +0000 Subject: [PATCH] AMDGPU: llvm.SI.fs.constant is a source of divergence Summary: This intrinsic is used to get flat-shaded fragment shader inputs. Those are uniform across a primitive, but a fragment shader wave may process pixels from multiple primitives (as indicated by the prim_mask), and so that's where divergence can arise. Reviewers: arsenm, tstellarAMD Subscribers: arsenm, llvm-commits Differential Revision: http://reviews.llvm.org/D19747 llvm-svn: 268259 --- .../Target/AMDGPU/AMDGPUTargetTransformInfo.cpp | 1 + .../DivergenceAnalysis/AMDGPU/interp-intrinsics.ll | 22 ++++++++++++++++++++++ 2 files changed, 23 insertions(+) create mode 100644 llvm/test/Analysis/DivergenceAnalysis/AMDGPU/interp-intrinsics.ll diff --git a/llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp b/llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp index 39da9dd..fabec27 100644 --- a/llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp +++ b/llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp @@ -260,6 +260,7 @@ static bool isIntrinsicSourceOfDivergence(const TargetIntrinsicInfo *TII, return false; case AMDGPUIntrinsic::SI_tid: case AMDGPUIntrinsic::SI_fs_interp: + case AMDGPUIntrinsic::SI_fs_constant: return true; } } diff --git a/llvm/test/Analysis/DivergenceAnalysis/AMDGPU/interp-intrinsics.ll b/llvm/test/Analysis/DivergenceAnalysis/AMDGPU/interp-intrinsics.ll new file mode 100644 index 0000000..d1c90ba --- /dev/null +++ b/llvm/test/Analysis/DivergenceAnalysis/AMDGPU/interp-intrinsics.ll @@ -0,0 +1,22 @@ +; RUN: opt -mtriple amdgcn--- -analyze -divergence %s | FileCheck %s + +; CHECK-LABEL: 'fs_interp' +; CHECK: DIVERGENT: %v = call float @llvm.SI.fs.interp( +define amdgpu_ps void @fs_interp(i32 inreg %prim_mask, <2 x i32> %interp_param) #1 { + %v = call float @llvm.SI.fs.interp(i32 0, i32 0, i32 %prim_mask, <2 x i32> %interp_param) + store volatile float %v, float addrspace(1)* undef + ret void +} + +; CHECK-LABEL: 'fs_constant' +; CHECK: DIVERGENT: %v = call float @llvm.SI.fs.constant( +define amdgpu_ps void @fs_constant(i32 inreg %prim_mask, <2 x i32> %interp_param) #1 { + %v = call float @llvm.SI.fs.constant(i32 0, i32 0, i32 %prim_mask) + store volatile float %v, float addrspace(1)* undef + ret void +} + +declare float @llvm.SI.fs.interp(i32, i32, i32, <2 x i32>) #0 +declare float @llvm.SI.fs.constant(i32, i32, i32) #0 + +attributes #0 = { nounwind readnone } -- 2.7.4