From 10f3fe3ee3943001c4944dc96a4ce291241289e1 Mon Sep 17 00:00:00 2001 From: "balazs.kilvady" Date: Fri, 23 Jan 2015 11:34:39 -0800 Subject: [PATCH] MIPS64: Remove the dependency of Zone on Isolate. Port c7b09aac317dd810d29b82061973199b80363b65 Original commit message: Along the way: - Thread isolate parameter explicitly through code that used to rely on getting it from the zone. - Canonicalize the parameter position of isolate and zone for affected code - Change Hydrogen New<> instruction templates to automatically pass isolate LOG=N BUG= Review URL: https://codereview.chromium.org/875533002 Cr-Commit-Position: refs/heads/master@{#26257} --- src/compiler/mips64/linkage-mips64.cc | 15 ++++++++------- src/mips64/regexp-macro-assembler-mips64.cc | 11 +++++------ src/mips64/regexp-macro-assembler-mips64.h | 3 ++- 3 files changed, 15 insertions(+), 14 deletions(-) diff --git a/src/compiler/mips64/linkage-mips64.cc b/src/compiler/mips64/linkage-mips64.cc index 0e1a590..fbd6fef 100644 --- a/src/compiler/mips64/linkage-mips64.cc +++ b/src/compiler/mips64/linkage-mips64.cc @@ -35,25 +35,26 @@ struct MipsLinkageHelperTraits { typedef LinkageHelper LH; -CallDescriptor* Linkage::GetJSCallDescriptor(int parameter_count, Zone* zone, +CallDescriptor* Linkage::GetJSCallDescriptor(Zone* zone, int parameter_count, CallDescriptor::Flags flags) { return LH::GetJSCallDescriptor(zone, parameter_count, flags); } CallDescriptor* Linkage::GetRuntimeCallDescriptor( - Runtime::FunctionId function, int parameter_count, - Operator::Properties properties, Zone* zone) { + Zone* zone, Runtime::FunctionId function, int parameter_count, + Operator::Properties properties) { return LH::GetRuntimeCallDescriptor(zone, function, parameter_count, properties); } CallDescriptor* Linkage::GetStubCallDescriptor( - const CallInterfaceDescriptor& descriptor, int stack_parameter_count, - CallDescriptor::Flags flags, Operator::Properties properties, Zone* zone) { - return LH::GetStubCallDescriptor(zone, descriptor, stack_parameter_count, - flags, properties); + Isolate* isolate, Zone* zone, const CallInterfaceDescriptor& descriptor, + int stack_parameter_count, CallDescriptor::Flags flags, + Operator::Properties properties) { + return LH::GetStubCallDescriptor(isolate, zone, descriptor, + stack_parameter_count, flags, properties); } diff --git a/src/mips64/regexp-macro-assembler-mips64.cc b/src/mips64/regexp-macro-assembler-mips64.cc index b20cab9..c1c0e4c 100644 --- a/src/mips64/regexp-macro-assembler-mips64.cc +++ b/src/mips64/regexp-macro-assembler-mips64.cc @@ -131,12 +131,11 @@ namespace internal { #define __ ACCESS_MASM(masm_) -RegExpMacroAssemblerMIPS::RegExpMacroAssemblerMIPS( - Mode mode, - int registers_to_save, - Zone* zone) - : NativeRegExpMacroAssembler(zone), - masm_(new MacroAssembler(zone->isolate(), NULL, kRegExpCodeSize)), +RegExpMacroAssemblerMIPS::RegExpMacroAssemblerMIPS(Isolate* isolate, Zone* zone, + Mode mode, + int registers_to_save) + : NativeRegExpMacroAssembler(isolate, zone), + masm_(new MacroAssembler(isolate, NULL, kRegExpCodeSize)), mode_(mode), num_registers_(registers_to_save), num_saved_registers_(registers_to_save), diff --git a/src/mips64/regexp-macro-assembler-mips64.h b/src/mips64/regexp-macro-assembler-mips64.h index dd4e8a9..ae4d25b 100644 --- a/src/mips64/regexp-macro-assembler-mips64.h +++ b/src/mips64/regexp-macro-assembler-mips64.h @@ -17,7 +17,8 @@ namespace internal { #ifndef V8_INTERPRETED_REGEXP class RegExpMacroAssemblerMIPS: public NativeRegExpMacroAssembler { public: - RegExpMacroAssemblerMIPS(Mode mode, int registers_to_save, Zone* zone); + RegExpMacroAssemblerMIPS(Isolate* isolate, Zone* zone, Mode mode, + int registers_to_save); virtual ~RegExpMacroAssemblerMIPS(); virtual int stack_limit_slack(); virtual void AdvanceCurrentPosition(int by); -- 2.7.4