From 10bea9c8730477ab97ec2e1f590aff52cf8e4e0e Mon Sep 17 00:00:00 2001 From: Leon Romanovsky Date: Fri, 19 Jan 2018 13:07:11 +0200 Subject: [PATCH] RDMA/mlx5: Remove redundant allocation warning print The kmalloc() failure to allocate memory generates enough information and doesn't need to be accompanied by another driver print. Fixes: d69a24e03659 ("IB/mlx5: Move IB event processing onto a workqueue") Signed-off-by: Leon Romanovsky Reviewed-by: Yuval Shaia Signed-off-by: Jason Gunthorpe --- drivers/infiniband/hw/mlx5/main.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c index f282e28..5007280 100644 --- a/drivers/infiniband/hw/mlx5/main.c +++ b/drivers/infiniband/hw/mlx5/main.c @@ -3345,19 +3345,16 @@ static void mlx5_ib_event(struct mlx5_core_dev *dev, void *context, struct mlx5_ib_event_work *work; work = kmalloc(sizeof(*work), GFP_ATOMIC); - if (work) { - INIT_WORK(&work->work, mlx5_ib_handle_event); - work->dev = dev; - work->param = param; - work->context = context; - work->event = event; - - queue_work(mlx5_ib_event_wq, &work->work); + if (!work) return; - } - dev_warn(&dev->pdev->dev, "%s: mlx5_dev_event: %d, with param: %lu dropped, couldn't allocate memory.\n", - __func__, event, param); + INIT_WORK(&work->work, mlx5_ib_handle_event); + work->dev = dev; + work->param = param; + work->context = context; + work->event = event; + + queue_work(mlx5_ib_event_wq, &work->work); } static int set_has_smi_cap(struct mlx5_ib_dev *dev) -- 2.7.4