From 1055aaa9cb442ed8a816a50793adc8c2eca7e65b Mon Sep 17 00:00:00 2001
From: Benjamin Otte <otte@redhat.com>
Date: Wed, 17 Mar 2010 19:35:10 +0100
Subject: [PATCH] Add -Wredundant-decls warning flag

Also fix compile issues
---
 configure.ac                        | 4 ++--
 ext/flac/gstflacdec.c               | 1 -
 ext/gdk_pixbuf/gstgdkpixbuf.c       | 5 -----
 ext/gdk_pixbuf/pixbufscale.c        | 5 +----
 ext/jpeg/gstjpeg.h                  | 1 +
 ext/jpeg/gstjpegdec.c               | 3 ---
 ext/jpeg/gstjpegenc.c               | 3 ---
 ext/soup/gstsouphttpsrc.c           | 2 --
 ext/wavpack/gstwavpackdec.c         | 1 -
 gst/deinterlace/tvtime/greedyh.c    | 2 --
 gst/deinterlace/tvtime/tomsmocomp.c | 2 --
 gst/equalizer/gstiirequalizer.c     | 3 ---
 gst/replaygain/gstrganalysis.c      | 4 ----
 gst/replaygain/gstrglimiter.c       | 4 ----
 gst/replaygain/gstrgvolume.c        | 3 ---
 gst/rtp/gstrtpg723pay.c             | 2 --
 gst/rtp/gstrtpg729pay.c             | 3 ---
 gst/rtpmanager/gstrtpbin.c          | 1 -
 gst/rtsp/gstrtspsrc.c               | 1 -
 gst/videomixer/videomixer.c         | 3 ---
 sys/v4l2/v4l2src_calls.c            | 1 -
 21 files changed, 4 insertions(+), 50 deletions(-)

diff --git a/configure.ac b/configure.ac
index d502da8..64a52df 100644
--- a/configure.ac
+++ b/configure.ac
@@ -272,10 +272,10 @@ dnl set location of plugin directory
 AG_GST_SET_PLUGINDIR
 
 dnl define an ERROR_CFLAGS Makefile variable
-AG_GST_SET_ERROR_CFLAGS($GST_GIT, [-Wmissing-declarations -Wmissing-prototypes])
+AG_GST_SET_ERROR_CFLAGS($GST_GIT, [-Wmissing-declarations -Wmissing-prototypes -Wredundant-decls])
 
 dnl define an ERROR_CXXFLAGS Makefile variable
-AG_GST_SET_ERROR_CXXFLAGS($GST_GIT, [-Wmissing-declarations -Wmissing-prototypes])
+AG_GST_SET_ERROR_CXXFLAGS($GST_GIT, [-Wmissing-declarations -Wmissing-prototypes -Wredundant-decls])
 
 dnl define correct level for debugging messages
 AG_GST_SET_LEVEL_DEFAULT($GST_GIT)
diff --git a/ext/flac/gstflacdec.c b/ext/flac/gstflacdec.c
index 3fc99b9..34339c0 100644
--- a/ext/flac/gstflacdec.c
+++ b/ext/flac/gstflacdec.c
@@ -120,7 +120,6 @@ static GstFlowReturn gst_flac_dec_chain (GstPad * pad, GstBuffer * buf);
 
 static void gst_flac_dec_reset_decoders (GstFlacDec * flacdec);
 static void gst_flac_dec_setup_decoder (GstFlacDec * flacdec);
-static void gst_flac_dec_setup_decoder (GstFlacDec * flacdec);
 
 static FLAC__StreamDecoderReadStatus
 gst_flac_dec_read_seekable (const FLAC__StreamDecoder * decoder,
diff --git a/ext/gdk_pixbuf/gstgdkpixbuf.c b/ext/gdk_pixbuf/gstgdkpixbuf.c
index 64ea99a..c6833a5 100644
--- a/ext/gdk_pixbuf/gstgdkpixbuf.c
+++ b/ext/gdk_pixbuf/gstgdkpixbuf.c
@@ -76,11 +76,6 @@ static GstStaticPadTemplate gst_gdk_pixbuf_src_template =
     GST_STATIC_CAPS (GST_VIDEO_CAPS_RGB "; " GST_VIDEO_CAPS_RGBA)
     );
 
-static void gst_gdk_pixbuf_base_init (gpointer g_class);
-static void gst_gdk_pixbuf_class_init (GstGdkPixbufClass * klass);
-static void gst_gdk_pixbuf_init (GstGdkPixbuf * filter,
-    GstGdkPixbufClass * klass);
-
 static void gst_gdk_pixbuf_set_property (GObject * object, guint prop_id,
     const GValue * value, GParamSpec * pspec);
 static void gst_gdk_pixbuf_get_property (GObject * object, guint prop_id,
diff --git a/ext/gdk_pixbuf/pixbufscale.c b/ext/gdk_pixbuf/pixbufscale.c
index bf0882c..564cebf 100644
--- a/ext/gdk_pixbuf/pixbufscale.c
+++ b/ext/gdk_pixbuf/pixbufscale.c
@@ -96,10 +96,6 @@ gst_pixbufscale_method_get_type (void)
   return pixbufscale_method_type;
 }
 
-static void gst_pixbufscale_base_init (gpointer g_class);
-static void gst_pixbufscale_class_init (GstPixbufScaleClass * klass);
-static void gst_pixbufscale_init (GstPixbufScale * pixbufscale,
-    GstPixbufScaleClass * kclass);
 static void gst_pixbufscale_set_property (GObject * object, guint prop_id,
     const GValue * value, GParamSpec * pspec);
 static void gst_pixbufscale_get_property (GObject * object, guint prop_id,
@@ -136,6 +132,7 @@ gst_pixbufscale_base_init (gpointer g_class)
   gst_element_class_add_pad_template (element_class,
       gst_static_pad_template_get (&gst_pixbufscale_sink_template));
 }
+
 static void
 gst_pixbufscale_class_init (GstPixbufScaleClass * klass)
 {
diff --git a/ext/jpeg/gstjpeg.h b/ext/jpeg/gstjpeg.h
index e301793..8b20199 100644
--- a/ext/jpeg/gstjpeg.h
+++ b/ext/jpeg/gstjpeg.h
@@ -26,6 +26,7 @@
 G_BEGIN_DECLS
 
 
+#define GST_TYPE_IDCT_METHOD (gst_idct_method_get_type())
 GType gst_idct_method_get_type (void);
 
 
diff --git a/ext/jpeg/gstjpegdec.c b/ext/jpeg/gstjpegdec.c
index 2258b1f..48b7661 100644
--- a/ext/jpeg/gstjpegdec.c
+++ b/ext/jpeg/gstjpegdec.c
@@ -62,9 +62,6 @@ enum
   PROP_IDCT_METHOD
 };
 
-extern GType gst_idct_method_get_type (void);
-#define GST_TYPE_IDCT_METHOD (gst_idct_method_get_type())
-
 static GstStaticPadTemplate gst_jpeg_dec_src_pad_template =
 GST_STATIC_PAD_TEMPLATE ("src",
     GST_PAD_SRC,
diff --git a/ext/jpeg/gstjpegenc.c b/ext/jpeg/gstjpegenc.c
index 534e2a0..37c0940 100644
--- a/ext/jpeg/gstjpegenc.c
+++ b/ext/jpeg/gstjpegenc.c
@@ -89,9 +89,6 @@ enum
   PROP_IDCT_METHOD
 };
 
-extern GType gst_idct_method_get_type (void);
-#define GST_TYPE_IDCT_METHOD (gst_idct_method_get_type())
-
 static void gst_jpegenc_base_init (gpointer g_class);
 static void gst_jpegenc_class_init (GstJpegEnc * klass);
 static void gst_jpegenc_init (GstJpegEnc * jpegenc);
diff --git a/ext/soup/gstsouphttpsrc.c b/ext/soup/gstsouphttpsrc.c
index 6c5baaa..6e5c32b 100644
--- a/ext/soup/gstsouphttpsrc.c
+++ b/ext/soup/gstsouphttpsrc.c
@@ -126,8 +126,6 @@ enum
 
 static void gst_soup_http_src_uri_handler_init (gpointer g_iface,
     gpointer iface_data);
-static void gst_soup_http_src_init (GstSoupHTTPSrc * src,
-    GstSoupHTTPSrcClass * g_class);
 static void gst_soup_http_src_finalize (GObject * gobject);
 
 static void gst_soup_http_src_set_property (GObject * object, guint prop_id,
diff --git a/ext/wavpack/gstwavpackdec.c b/ext/wavpack/gstwavpackdec.c
index 4100027..7fc1da1 100644
--- a/ext/wavpack/gstwavpackdec.c
+++ b/ext/wavpack/gstwavpackdec.c
@@ -86,7 +86,6 @@ static gboolean gst_wavpack_dec_sink_event (GstPad * pad, GstEvent * event);
 static void gst_wavpack_dec_finalize (GObject * object);
 static GstStateChangeReturn gst_wavpack_dec_change_state (GstElement * element,
     GstStateChange transition);
-static gboolean gst_wavpack_dec_sink_event (GstPad * pad, GstEvent * event);
 static void gst_wavpack_dec_post_tags (GstWavpackDec * dec);
 
 GST_BOILERPLATE (GstWavpackDec, gst_wavpack_dec, GstElement, GST_TYPE_ELEMENT);
diff --git a/gst/deinterlace/tvtime/greedyh.c b/gst/deinterlace/tvtime/greedyh.c
index e443324..c72d73d 100644
--- a/gst/deinterlace/tvtime/greedyh.c
+++ b/gst/deinterlace/tvtime/greedyh.c
@@ -47,8 +47,6 @@
 #define GST_DEINTERLACE_METHOD_GREEDY_H_CLASS(klass)	(G_TYPE_CHECK_CLASS_CAST ((klass), GST_TYPE_DEINTERLACE_METHOD_GREEDY_H, GstDeinterlaceMethodGreedyHClass))
 #define GST_DEINTERLACE_METHOD_GREEDY_H_CAST(obj)	((GstDeinterlaceMethodGreedyH*)(obj))
 
-GType gst_deinterlace_method_greedy_h_get_type (void);
-
 typedef struct
 {
   GstDeinterlaceMethod parent;
diff --git a/gst/deinterlace/tvtime/tomsmocomp.c b/gst/deinterlace/tvtime/tomsmocomp.c
index 50687f1..cab6faf 100644
--- a/gst/deinterlace/tvtime/tomsmocomp.c
+++ b/gst/deinterlace/tvtime/tomsmocomp.c
@@ -43,8 +43,6 @@
 #define GST_DEINTERLACE_METHOD_TOMSMOCOMP_CLASS(klass)	(G_TYPE_CHECK_CLASS_CAST ((klass), GST_TYPE_DEINTERLACE_METHOD_TOMSMOCOMP, GstDeinterlaceMethodTomsMoCompClass))
 #define GST_DEINTERLACE_METHOD_TOMSMOCOMP_CAST(obj)	((GstDeinterlaceMethodTomsMoComp*)(obj))
 
-GType gst_deinterlace_method_tomsmocomp_get_type (void);
-
 typedef struct
 {
   GstDeinterlaceMethod parent;
diff --git a/gst/equalizer/gstiirequalizer.c b/gst/equalizer/gstiirequalizer.c
index 48a5461..b679d4d 100644
--- a/gst/equalizer/gstiirequalizer.c
+++ b/gst/equalizer/gstiirequalizer.c
@@ -47,9 +47,6 @@ static gboolean gst_iir_equalizer_setup (GstAudioFilter * filter,
 static GstFlowReturn gst_iir_equalizer_transform_ip (GstBaseTransform * btrans,
     GstBuffer * buf);
 
-GST_DEBUG_CATEGORY_EXTERN (equalizer_debug);
-#define GST_CAT_DEFAULT equalizer_debug
-
 #define ALLOWED_CAPS \
     "audio/x-raw-int,"                                                \
     " depth=(int)16,"                                                 \
diff --git a/gst/replaygain/gstrganalysis.c b/gst/replaygain/gstrganalysis.c
index 1c6d1e8..dbae1cd 100644
--- a/gst/replaygain/gstrganalysis.c
+++ b/gst/replaygain/gstrganalysis.c
@@ -135,10 +135,6 @@ static GstStaticPadTemplate src_factory = GST_STATIC_PAD_TEMPLATE ("src",
 GST_BOILERPLATE (GstRgAnalysis, gst_rg_analysis, GstBaseTransform,
     GST_TYPE_BASE_TRANSFORM);
 
-static void gst_rg_analysis_class_init (GstRgAnalysisClass * klass);
-static void gst_rg_analysis_init (GstRgAnalysis * filter,
-    GstRgAnalysisClass * gclass);
-
 static void gst_rg_analysis_set_property (GObject * object, guint prop_id,
     const GValue * value, GParamSpec * pspec);
 static void gst_rg_analysis_get_property (GObject * object, guint prop_id,
diff --git a/gst/replaygain/gstrglimiter.c b/gst/replaygain/gstrglimiter.c
index 43c7b01..7f29ed7 100644
--- a/gst/replaygain/gstrglimiter.c
+++ b/gst/replaygain/gstrglimiter.c
@@ -70,10 +70,6 @@ static GstStaticPadTemplate src_factory = GST_STATIC_PAD_TEMPLATE ("src",
 GST_BOILERPLATE (GstRgLimiter, gst_rg_limiter, GstBaseTransform,
     GST_TYPE_BASE_TRANSFORM);
 
-static void gst_rg_limiter_class_init (GstRgLimiterClass * klass);
-static void gst_rg_limiter_init (GstRgLimiter * filter,
-    GstRgLimiterClass * gclass);
-
 static void gst_rg_limiter_set_property (GObject * object, guint prop_id,
     const GValue * value, GParamSpec * pspec);
 static void gst_rg_limiter_get_property (GObject * object, guint prop_id,
diff --git a/gst/replaygain/gstrgvolume.c b/gst/replaygain/gstrgvolume.c
index cf5a914..06359de 100644
--- a/gst/replaygain/gstrgvolume.c
+++ b/gst/replaygain/gstrgvolume.c
@@ -122,9 +122,6 @@ static GstStaticPadTemplate src_template = GST_STATIC_PAD_TEMPLATE ("src",
 
 GST_BOILERPLATE (GstRgVolume, gst_rg_volume, GstBin, GST_TYPE_BIN);
 
-static void gst_rg_volume_class_init (GstRgVolumeClass * klass);
-static void gst_rg_volume_init (GstRgVolume * self, GstRgVolumeClass * gclass);
-
 static void gst_rg_volume_set_property (GObject * object, guint prop_id,
     const GValue * value, GParamSpec * pspec);
 static void gst_rg_volume_get_property (GObject * object, guint prop_id,
diff --git a/gst/rtp/gstrtpg723pay.c b/gst/rtp/gstrtpg723pay.c
index 06b5d76..00599ba 100644
--- a/gst/rtp/gstrtpg723pay.c
+++ b/gst/rtp/gstrtpg723pay.c
@@ -68,8 +68,6 @@ static GstStaticPadTemplate gst_rtp_g723_pay_src_template =
         "clock-rate = (int) 8000, " "encoding-name = (string) \"G723\"")
     );
 
-static void gst_rtp_g723_pay_init (GstRTPG723Pay * pay,
-    GstRTPG723PayClass * klass);
 static void gst_rtp_g723_pay_finalize (GObject * object);
 
 static GstStateChangeReturn gst_rtp_g723_pay_change_state (GstElement * element,
diff --git a/gst/rtp/gstrtpg729pay.c b/gst/rtp/gstrtpg729pay.c
index c6b5fe0..0e84f1d 100644
--- a/gst/rtp/gstrtpg729pay.c
+++ b/gst/rtp/gstrtpg729pay.c
@@ -78,9 +78,6 @@ static GstStaticPadTemplate gst_rtp_g729_pay_src_template =
         "clock-rate = (int) 8000, " "encoding-name = (string) \"G729\"")
     );
 
-static void
-gst_rtp_g729_pay_init (GstRTPG729Pay * pay, GstRTPG729PayClass * klass);
-
 GST_BOILERPLATE (GstRTPG729Pay, gst_rtp_g729_pay, GstBaseRTPAudioPayload,
     GST_TYPE_BASE_RTP_AUDIO_PAYLOAD);
 
diff --git a/gst/rtpmanager/gstrtpbin.c b/gst/rtpmanager/gstrtpbin.c
index d07d719..f0b5a23 100644
--- a/gst/rtpmanager/gstrtpbin.c
+++ b/gst/rtpmanager/gstrtpbin.c
@@ -1262,7 +1262,6 @@ static GstPad *gst_rtp_bin_request_new_pad (GstElement * element,
     GstPadTemplate * templ, const gchar * name);
 static void gst_rtp_bin_release_pad (GstElement * element, GstPad * pad);
 static void gst_rtp_bin_handle_message (GstBin * bin, GstMessage * message);
-static void gst_rtp_bin_clear_pt_map (GstRtpBin * bin);
 
 GST_BOILERPLATE (GstRtpBin, gst_rtp_bin, GstBin, GST_TYPE_BIN);
 
diff --git a/gst/rtsp/gstrtspsrc.c b/gst/rtsp/gstrtspsrc.c
index df68614..7573e9a 100644
--- a/gst/rtsp/gstrtspsrc.c
+++ b/gst/rtsp/gstrtspsrc.c
@@ -211,7 +211,6 @@ gst_rtsp_nat_method_get_type (void)
   return rtsp_nat_method_type;
 }
 
-static void gst_rtspsrc_base_init (gpointer g_class);
 static void gst_rtspsrc_finalize (GObject * object);
 
 static void gst_rtspsrc_set_property (GObject * object, guint prop_id,
diff --git a/gst/videomixer/videomixer.c b/gst/videomixer/videomixer.c
index bb72a59..157ed2b 100644
--- a/gst/videomixer/videomixer.c
+++ b/gst/videomixer/videomixer.c
@@ -88,9 +88,6 @@ GST_DEBUG_CATEGORY (gst_videomixer_debug);
 
 static GType gst_videomixer_get_type (void);
 
-static void gst_videomixer_pad_class_init (GstVideoMixerPadClass * klass);
-static void gst_videomixer_pad_init (GstVideoMixerPad * mixerpad);
-
 static void gst_videomixer_pad_get_property (GObject * object, guint prop_id,
     GValue * value, GParamSpec * pspec);
 static void gst_videomixer_pad_set_property (GObject * object, guint prop_id,
diff --git a/sys/v4l2/v4l2src_calls.c b/sys/v4l2/v4l2src_calls.c
index c07748a..9a2ff5d 100644
--- a/sys/v4l2/v4l2src_calls.c
+++ b/sys/v4l2/v4l2src_calls.c
@@ -47,7 +47,6 @@
 
 #include "gst/gst-i18n-plugin.h"
 
-GST_DEBUG_CATEGORY_EXTERN (v4l2src_debug);
 #define GST_CAT_DEFAULT v4l2src_debug
 GST_DEBUG_CATEGORY_EXTERN (GST_CAT_PERFORMANCE);
 
-- 
2.7.4