From 0fafb8fc43226c8d46d11fed13f8d36939789ddc Mon Sep 17 00:00:00 2001 From: ilho Date: Mon, 28 Jan 2019 16:52:32 +0900 Subject: [PATCH] Fix possibility of double free Change-Id: I907211b9896d3de040c4da76778c942ff7890c75 Signed-off-by: ilho --- installer/pkgmgr_installer.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/installer/pkgmgr_installer.c b/installer/pkgmgr_installer.c index a15485f..f69db39 100644 --- a/installer/pkgmgr_installer.c +++ b/installer/pkgmgr_installer.c @@ -459,10 +459,12 @@ pkgmgr_installer_receive_request(pkgmgr_installer *pi, free(pi->pkgmgr_info); pi->pkgmgr_info = strndup(optarg, MAX_STRLEN); DBG("option is [i] pkgid[%s]", pi->pkgmgr_info); - if (pi->pkgmgr_info && strlen(pi->pkgmgr_info) == 0) + if (pi->pkgmgr_info && strlen(pi->pkgmgr_info) == 0) { free(pi->pkgmgr_info); - else + pi->pkgmgr_info = NULL; + } else { mode = 'i'; + } break; case 'e': /* install */ -- 2.34.1