From 0f7e6b2cead0c7d527ef68ededb27e0afd71d819 Mon Sep 17 00:00:00 2001
From: Behdad Esfahbod <behdad@behdad.org>
Date: Wed, 20 May 2009 04:16:35 -0400
Subject: [PATCH] [GPOS] Fix more brokenness

---
 src/Makefile.am                 |  2 +-
 src/hb-ot-layout-gpos-private.h | 37 ++++++++++++++++++++-----------------
 src/hb-ot-layout.cc             |  7 +++++++
 src/hb-ot-layout.h              |  5 +++++
 4 files changed, 33 insertions(+), 18 deletions(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index e5ea114..e04419e 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -4,7 +4,7 @@ INCLUDES = 					\
 	-I $(srcdir)				\
 	$(FREETYPE_CFLAGS)			\
 	$(GLIB_CFLAGS)
-CXX = gcc $(GCCOPTS) -fno-rtti -fno-exceptions -Wabi -Wpadded -Wcast-align
+CXX = gcc $(GCCOPTS) -g -fno-rtti -fno-exceptions -Wabi -Wpadded -Wcast-align
 
 noinst_LTLIBRARIES = libharfbuzz-1.la
 
diff --git a/src/hb-ot-layout-gpos-private.h b/src/hb-ot-layout-gpos-private.h
index 0373a59..600ef96 100644
--- a/src/hb-ot-layout-gpos-private.h
+++ b/src/hb-ot-layout-gpos-private.h
@@ -551,18 +551,6 @@ struct CursivePosFormat1
   private:
   inline bool apply (APPLY_ARG_DEF) const
   {
-    struct hb_ot_layout_t::gpos_info_t *gpi = &layout->gpos_info;
-    hb_codepoint_t last_pos = gpi->last;
-    gpi->last = 0xFFFF;
-
-    /* We don't handle mark glyphs here. */
-    if (property == HB_OT_LAYOUT_GLYPH_CLASS_MARK)
-      return false;
-
-    unsigned int index = (this+coverage) (IN_CURGLYPH ());
-    if (HB_LIKELY (index == NOT_COVERED))
-      return false;
-
     /* Now comes the messiest part of the whole OpenType
        specification.  At first glance, cursive connections seem easy
        to understand, but there are pitfalls!  The reason is that
@@ -680,6 +668,18 @@ struct CursivePosFormat1
        Since horizontal advance widths or vertical advance heights
        can be used alone but not together, no ambiguity occurs.        */
 
+    struct hb_ot_layout_t::gpos_info_t *gpi = &layout->gpos_info;
+    hb_codepoint_t last_pos = gpi->last;
+    gpi->last = 0xFFFF;
+
+    /* We don't handle mark glyphs here. */
+    if (property == HB_OT_LAYOUT_GLYPH_CLASS_MARK)
+      return false;
+
+    unsigned int index = (this+coverage) (IN_CURGLYPH ());
+    if (HB_LIKELY (index == NOT_COVERED))
+      return false;
+
     const EntryExitRecord &record = entryExitRecord[index];
 
     hb_position_t entry_x, entry_y, exit_x, exit_y;
@@ -696,24 +696,27 @@ struct CursivePosFormat1
     }
     else
     {
-      POSITION (gpi->last)->x_advance   = gpi->anchor_x - entry_x;
-      POSITION (gpi->last)->new_advance = TRUE;
+      POSITION (last_pos)->x_advance   = gpi->anchor_x - entry_x;
+      POSITION (last_pos)->new_advance = TRUE;
     }
 
     if  (lookup_flag & LookupFlag::RightToLeft)
     {
-      POSITION (gpi->last)->cursive_chain = gpi->last - buffer->in_pos;
-      POSITION (gpi->last)->y_pos = entry_y - gpi->anchor_y;
+      POSITION (last_pos)->cursive_chain = last_pos - buffer->in_pos;
+      POSITION (last_pos)->y_pos = entry_y - gpi->anchor_y;
     }
     else
     {
-      POSITION (buffer->in_pos)->cursive_chain = buffer->in_pos - gpi->last;
+      POSITION (buffer->in_pos)->cursive_chain = buffer->in_pos - last_pos;
       POSITION (buffer->in_pos)->y_pos = gpi->anchor_y - entry_y;
     }
 
   end:
     if (record.exitAnchor)
+    {
+      gpi->last = buffer->in_pos;
       (this+record.exitAnchor).get_anchor (layout, IN_CURGLYPH (), &gpi->anchor_x, &gpi->anchor_y);
+    }
 
     buffer->in_pos++;
     return true;
diff --git a/src/hb-ot-layout.cc b/src/hb-ot-layout.cc
index 4bb2eb5..ced7c95 100644
--- a/src/hb-ot-layout.cc
+++ b/src/hb-ot-layout.cc
@@ -82,6 +82,13 @@ hb_ot_layout_destroy (hb_ot_layout_t *layout)
   free (layout);
 }
 
+void
+hb_ot_layout_set_direction (hb_ot_layout_t *layout,
+			    hb_bool_t r2l)
+{
+  layout->gpos_info.r2l = !!r2l;
+}
+
 /*
  * GDEF
  */
diff --git a/src/hb-ot-layout.h b/src/hb-ot-layout.h
index f907b65..3e83c36 100644
--- a/src/hb-ot-layout.h
+++ b/src/hb-ot-layout.h
@@ -47,6 +47,11 @@ hb_ot_layout_create_for_data (const char *font_data,
 void
 hb_ot_layout_destroy (hb_ot_layout_t *layout);
 
+/* XXX */
+void
+hb_ot_layout_set_direction (hb_ot_layout_t *layout,
+			    hb_bool_t r2l);
+
 /* TODO sanitizing API/constructor (make_writable_func_t) */
 /* TODO get_table_func_t constructor */
 
-- 
2.7.4