From 0f6fb7fe402779a16ecb443015a03089179e27de Mon Sep 17 00:00:00 2001 From: jusung Date: Fri, 19 Feb 2021 14:01:30 +0900 Subject: [PATCH] Fix static analysis issue Signed-off-by: jusung --- src/server/get_appinfo_request_handler.cc | 4 +++- src/server/get_cert_request_handler.cc | 4 +++- src/server/get_pkginfo_request_handler.cc | 4 +++- src/server/query_request_handler.cc | 4 +++- src/server/set_cert_request_handler.cc | 4 +++- src/server/set_pkginfo_request_handler.cc | 4 +++- 6 files changed, 18 insertions(+), 6 deletions(-) diff --git a/src/server/get_appinfo_request_handler.cc b/src/server/get_appinfo_request_handler.cc index fb42da8..181cac9 100644 --- a/src/server/get_appinfo_request_handler.cc +++ b/src/server/get_appinfo_request_handler.cc @@ -18,10 +18,12 @@ namespace request_handler { bool GetAppinfoRequestHandler::HandleRequest(unsigned char* data, int size, std::string locale) { auto abstract_parcel = ParcelableFactory::GetInst().CreateParcel(data, size); - if (abstract_parcel->GetType() != ParcelableType::Filter) + if (abstract_parcel == nullptr || abstract_parcel->GetType() != ParcelableType::Filter) return false; auto* parcel = dynamic_cast(abstract_parcel.get()); + if (parcel == nullptr) + return false; AppInfoDBHandler db(parcel->GetUid()); db.SetLocale(locale); diff --git a/src/server/get_cert_request_handler.cc b/src/server/get_cert_request_handler.cc index 61c886e..5caddc1 100644 --- a/src/server/get_cert_request_handler.cc +++ b/src/server/get_cert_request_handler.cc @@ -17,10 +17,12 @@ namespace request_handler { bool GetCertRequestHandler::HandleRequest(unsigned char* data, int size, std::string locale) { auto abstract_parcel = ParcelableFactory::GetInst().CreateParcel(data, size); - if (abstract_parcel->GetType() != ParcelableType::CertInfo) + if (abstract_parcel == nullptr || abstract_parcel->GetType() != ParcelableType::CertInfo) return false; auto* parcel = dynamic_cast(abstract_parcel.get()); + if (parcel == nullptr) + return false; CertGetDBHandler db(parcel->GetUid()); db.SetLocale(locale); diff --git a/src/server/get_pkginfo_request_handler.cc b/src/server/get_pkginfo_request_handler.cc index c639874..4f003c6 100644 --- a/src/server/get_pkginfo_request_handler.cc +++ b/src/server/get_pkginfo_request_handler.cc @@ -18,10 +18,12 @@ namespace request_handler { bool GetPkginfoRequestHandler::HandleRequest(unsigned char* data, int size, std::string locale) { auto abstract_parcel = ParcelableFactory::GetInst().CreateParcel(data, size); - if (abstract_parcel->GetType() != ParcelableType::Filter) + if (abstract_parcel == nullptr || abstract_parcel->GetType() != ParcelableType::Filter) return false; auto* parcel = dynamic_cast(abstract_parcel.get()); + if (parcel == nullptr) + return false; PkgGetDBHandler db(parcel->GetUid()); db.SetLocale(locale); diff --git a/src/server/query_request_handler.cc b/src/server/query_request_handler.cc index b34030e..33662a2 100644 --- a/src/server/query_request_handler.cc +++ b/src/server/query_request_handler.cc @@ -18,10 +18,12 @@ namespace request_handler { bool QueryRequestHandler::HandleRequest(unsigned char* data, int size, std::string locale) { auto abstract_parcel = ParcelableFactory::GetInst().CreateParcel(data, size); - if (abstract_parcel->GetType() != ParcelableType::Query) + if (abstract_parcel == nullptr || abstract_parcel->GetType() != ParcelableType::Query) return false; auto* parcel = dynamic_cast(abstract_parcel.get()); + if (parcel == nullptr) + return false; QueryHandler db(parcel->GetUid()); db.SetLocale(locale); diff --git a/src/server/set_cert_request_handler.cc b/src/server/set_cert_request_handler.cc index c13d85a..b9cc298 100644 --- a/src/server/set_cert_request_handler.cc +++ b/src/server/set_cert_request_handler.cc @@ -18,10 +18,12 @@ namespace request_handler { bool SetCertRequestHandler::HandleRequest(unsigned char* data, int size, std::string locale) { auto abstract_parcel = ParcelableFactory::GetInst().CreateParcel(data, size); - if (abstract_parcel->GetType() != ParcelableType::CertInfo) + if (abstract_parcel == nullptr || abstract_parcel->GetType() != ParcelableType::CertInfo) return false; auto* parcel = dynamic_cast(abstract_parcel.get()); + if (parcel == nullptr) + return false; CertSetDBHandler db(parcel->GetUid()); db.SetLocale(locale); diff --git a/src/server/set_pkginfo_request_handler.cc b/src/server/set_pkginfo_request_handler.cc index 305919b..569ef9f 100644 --- a/src/server/set_pkginfo_request_handler.cc +++ b/src/server/set_pkginfo_request_handler.cc @@ -18,10 +18,12 @@ namespace request_handler { bool SetPkginfoRequestHandler::HandleRequest(unsigned char* data, int size, std::string locale) { auto abstract_parcel = ParcelableFactory::GetInst().CreateParcel(data, size); - if (abstract_parcel->GetType() != ParcelableType::PkgInfo) + if (abstract_parcel == nullptr || abstract_parcel->GetType() != ParcelableType::PkgInfo) return false; auto* parcel = dynamic_cast(abstract_parcel.get()); + if (parcel == nullptr) + return false; PkgSetDBHandler db(parcel->GetUid()); db.SetLocale(locale); -- 2.7.4