From 0ede82e132c76e40416ba92c0ee0282e39097618 Mon Sep 17 00:00:00 2001 From: Hyung-Kyu Choi Date: Sat, 1 Jul 2017 09:11:52 +0900 Subject: [PATCH] Remove unnecessary update of RegRecord in LSRA (dotnet/coreclr#12474) * Remove unnecessary update of RegRecord We don't need to clear assignedInterval of regRec, because it was already cleared by checkAndClearInterval() above. Signed-off-by: Hyung-Kyu Choi * Apply review feedback - Add a assertion and comment for the assertion Signed-off-by: Hyung-Kyu Choi Commit migrated from https://github.com/dotnet/coreclr/commit/f0d3c439dc16a3218d53578f14c973696de04cb1 --- src/coreclr/src/jit/lsra.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/coreclr/src/jit/lsra.cpp b/src/coreclr/src/jit/lsra.cpp index 108fbe6..98fcf92 100644 --- a/src/coreclr/src/jit/lsra.cpp +++ b/src/coreclr/src/jit/lsra.cpp @@ -6457,7 +6457,9 @@ void LinearScan::unassignPhysReg(RegRecord* regRec, RefPosition* spillRefPositio { // This must have been a temporary copy reg, but we can't assert that because there // may have been intervening RefPositions that were not copyRegs. - regRec->assignedInterval = nullptr; + + // reg->assignedInterval has already been set to nullptr by checkAndClearInterval() + assert(regRec->assignedInterval == nullptr); return; } -- 2.7.4