From 0ede5804ca3b42c831f7440ec29bc7187e5376bb Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Mon, 16 Dec 2013 12:49:23 +0300 Subject: [PATCH] tgafb: potential NULL dereference in init Static checkers complain that there are paths where "tga_type_name" can be NULL. I've re-arranged the code slightly so that's impossible. Signed-off-by: Dan Carpenter Signed-off-by: Tomi Valkeinen --- drivers/video/tgafb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/video/tgafb.c b/drivers/video/tgafb.c index 5e94c6e4..07c7df9 100644 --- a/drivers/video/tgafb.c +++ b/drivers/video/tgafb.c @@ -1490,10 +1490,9 @@ tgafb_init_fix(struct fb_info *info) if (tga_bus_tc) tga_type_name = "Digital ZLX-E3"; break; - default: - tga_type_name = "Unknown"; - break; } + if (!tga_type_name) + tga_type_name = "Unknown"; strlcpy(info->fix.id, tga_type_name, sizeof(info->fix.id)); -- 2.7.4