From 0e61d02c05c9f35f0e1e242663eb89aab2db7e12 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 5 Nov 2020 08:44:38 -0500 Subject: [PATCH] [libc++] Correct XFAILs for the C++20 Synchronization Library Technically, these tests don't only fail against macosx10.9 to 10.15, but really against any released macOS yet. --- .../atomics.types.operations.wait/atomic_wait.pass.cpp | 4 +++- libcxx/test/std/thread/thread.barrier/arrive.pass.cpp | 4 +++- libcxx/test/std/thread/thread.barrier/arrive_and_drop.pass.cpp | 4 +++- libcxx/test/std/thread/thread.barrier/arrive_and_wait.pass.cpp | 4 +++- libcxx/test/std/thread/thread.barrier/completion.pass.cpp | 4 +++- libcxx/test/std/thread/thread.latch/arrive_and_wait.pass.cpp | 4 +++- libcxx/test/std/thread/thread.latch/count_down.pass.cpp | 4 +++- libcxx/test/std/thread/thread.latch/try_wait.pass.cpp | 4 +++- libcxx/test/std/thread/thread.semaphore/acquire.pass.cpp | 4 +++- libcxx/test/std/thread/thread.semaphore/binary.pass.cpp | 4 +++- libcxx/test/std/thread/thread.semaphore/release.pass.cpp | 4 +++- libcxx/test/std/thread/thread.semaphore/timed.pass.cpp | 4 +++- libcxx/test/std/thread/thread.semaphore/try_acquire.pass.cpp | 4 +++- 13 files changed, 39 insertions(+), 13 deletions(-) diff --git a/libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.wait/atomic_wait.pass.cpp b/libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.wait/atomic_wait.pass.cpp index 1376098..b5a345d 100644 --- a/libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.wait/atomic_wait.pass.cpp +++ b/libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.wait/atomic_wait.pass.cpp @@ -9,7 +9,9 @@ // UNSUPPORTED: libcpp-has-no-threads // XFAIL: c++03 -// This test requires the dylib support introduced in D68480 +// This test requires the dylib support introduced in D68480, +// which hasn't shipped yet. +// XFAIL: with_system_cxx_lib=macosx // XFAIL: with_system_cxx_lib=macosx10.15 // XFAIL: with_system_cxx_lib=macosx10.14 // XFAIL: with_system_cxx_lib=macosx10.13 diff --git a/libcxx/test/std/thread/thread.barrier/arrive.pass.cpp b/libcxx/test/std/thread/thread.barrier/arrive.pass.cpp index ce6d159..59a2197 100644 --- a/libcxx/test/std/thread/thread.barrier/arrive.pass.cpp +++ b/libcxx/test/std/thread/thread.barrier/arrive.pass.cpp @@ -9,7 +9,9 @@ // UNSUPPORTED: libcpp-has-no-threads // UNSUPPORTED: c++03, c++11 -// This test requires the dylib support introduced in D68480 +// This test requires the dylib support introduced in D68480, +// which hasn't shipped yet. +// XFAIL: with_system_cxx_lib=macosx // XFAIL: with_system_cxx_lib=macosx10.15 // XFAIL: with_system_cxx_lib=macosx10.14 // XFAIL: with_system_cxx_lib=macosx10.13 diff --git a/libcxx/test/std/thread/thread.barrier/arrive_and_drop.pass.cpp b/libcxx/test/std/thread/thread.barrier/arrive_and_drop.pass.cpp index 0477150..00f8dfa 100644 --- a/libcxx/test/std/thread/thread.barrier/arrive_and_drop.pass.cpp +++ b/libcxx/test/std/thread/thread.barrier/arrive_and_drop.pass.cpp @@ -9,7 +9,9 @@ // UNSUPPORTED: libcpp-has-no-threads // UNSUPPORTED: c++03, c++11 -// This test requires the dylib support introduced in D68480 +// This test requires the dylib support introduced in D68480, +// which hasn't shipped yet. +// XFAIL: with_system_cxx_lib=macosx // XFAIL: with_system_cxx_lib=macosx10.15 // XFAIL: with_system_cxx_lib=macosx10.14 // XFAIL: with_system_cxx_lib=macosx10.13 diff --git a/libcxx/test/std/thread/thread.barrier/arrive_and_wait.pass.cpp b/libcxx/test/std/thread/thread.barrier/arrive_and_wait.pass.cpp index 335812d..b3da00e 100644 --- a/libcxx/test/std/thread/thread.barrier/arrive_and_wait.pass.cpp +++ b/libcxx/test/std/thread/thread.barrier/arrive_and_wait.pass.cpp @@ -9,7 +9,9 @@ // UNSUPPORTED: libcpp-has-no-threads // UNSUPPORTED: c++03, c++11 -// This test requires the dylib support introduced in D68480 +// This test requires the dylib support introduced in D68480, +// which hasn't shipped yet. +// XFAIL: with_system_cxx_lib=macosx // XFAIL: with_system_cxx_lib=macosx10.15 // XFAIL: with_system_cxx_lib=macosx10.14 // XFAIL: with_system_cxx_lib=macosx10.13 diff --git a/libcxx/test/std/thread/thread.barrier/completion.pass.cpp b/libcxx/test/std/thread/thread.barrier/completion.pass.cpp index 864ca0a..7d4e811 100644 --- a/libcxx/test/std/thread/thread.barrier/completion.pass.cpp +++ b/libcxx/test/std/thread/thread.barrier/completion.pass.cpp @@ -9,7 +9,9 @@ // UNSUPPORTED: libcpp-has-no-threads // UNSUPPORTED: c++03, c++11 -// This test requires the dylib support introduced in D68480 +// This test requires the dylib support introduced in D68480, +// which hasn't shipped yet. +// XFAIL: with_system_cxx_lib=macosx // XFAIL: with_system_cxx_lib=macosx10.15 // XFAIL: with_system_cxx_lib=macosx10.14 // XFAIL: with_system_cxx_lib=macosx10.13 diff --git a/libcxx/test/std/thread/thread.latch/arrive_and_wait.pass.cpp b/libcxx/test/std/thread/thread.latch/arrive_and_wait.pass.cpp index 88cd578..c4c4b2e 100644 --- a/libcxx/test/std/thread/thread.latch/arrive_and_wait.pass.cpp +++ b/libcxx/test/std/thread/thread.latch/arrive_and_wait.pass.cpp @@ -9,7 +9,9 @@ // UNSUPPORTED: libcpp-has-no-threads // UNSUPPORTED: c++03, c++11 -// This test requires the dylib support introduced in D68480 +// This test requires the dylib support introduced in D68480, +// which hasn't shipped yet. +// XFAIL: with_system_cxx_lib=macosx // XFAIL: with_system_cxx_lib=macosx10.15 // XFAIL: with_system_cxx_lib=macosx10.14 // XFAIL: with_system_cxx_lib=macosx10.13 diff --git a/libcxx/test/std/thread/thread.latch/count_down.pass.cpp b/libcxx/test/std/thread/thread.latch/count_down.pass.cpp index b411d86..336b321 100644 --- a/libcxx/test/std/thread/thread.latch/count_down.pass.cpp +++ b/libcxx/test/std/thread/thread.latch/count_down.pass.cpp @@ -9,7 +9,9 @@ // UNSUPPORTED: libcpp-has-no-threads // UNSUPPORTED: c++03, c++11 -// This test requires the dylib support introduced in D68480 +// This test requires the dylib support introduced in D68480, +// which hasn't shipped yet. +// XFAIL: with_system_cxx_lib=macosx // XFAIL: with_system_cxx_lib=macosx10.15 // XFAIL: with_system_cxx_lib=macosx10.14 // XFAIL: with_system_cxx_lib=macosx10.13 diff --git a/libcxx/test/std/thread/thread.latch/try_wait.pass.cpp b/libcxx/test/std/thread/thread.latch/try_wait.pass.cpp index e06b80f..476ec8b 100644 --- a/libcxx/test/std/thread/thread.latch/try_wait.pass.cpp +++ b/libcxx/test/std/thread/thread.latch/try_wait.pass.cpp @@ -9,7 +9,9 @@ // UNSUPPORTED: libcpp-has-no-threads // UNSUPPORTED: c++03, c++11 -// This test requires the dylib support introduced in D68480 +// This test requires the dylib support introduced in D68480, +// which hasn't shipped yet. +// XFAIL: with_system_cxx_lib=macosx // XFAIL: with_system_cxx_lib=macosx10.15 // XFAIL: with_system_cxx_lib=macosx10.14 // XFAIL: with_system_cxx_lib=macosx10.13 diff --git a/libcxx/test/std/thread/thread.semaphore/acquire.pass.cpp b/libcxx/test/std/thread/thread.semaphore/acquire.pass.cpp index 87da3fd..f8466ba 100644 --- a/libcxx/test/std/thread/thread.semaphore/acquire.pass.cpp +++ b/libcxx/test/std/thread/thread.semaphore/acquire.pass.cpp @@ -9,7 +9,9 @@ // UNSUPPORTED: libcpp-has-no-threads // UNSUPPORTED: c++03, c++11 -// This test requires the dylib support introduced in D68480 +// This test requires the dylib support introduced in D68480, +// which hasn't shipped yet. +// XFAIL: with_system_cxx_lib=macosx // XFAIL: with_system_cxx_lib=macosx10.15 // XFAIL: with_system_cxx_lib=macosx10.14 // XFAIL: with_system_cxx_lib=macosx10.13 diff --git a/libcxx/test/std/thread/thread.semaphore/binary.pass.cpp b/libcxx/test/std/thread/thread.semaphore/binary.pass.cpp index 040201f..5ef65f3 100644 --- a/libcxx/test/std/thread/thread.semaphore/binary.pass.cpp +++ b/libcxx/test/std/thread/thread.semaphore/binary.pass.cpp @@ -9,7 +9,9 @@ // UNSUPPORTED: libcpp-has-no-threads // UNSUPPORTED: c++03, c++11 -// This test requires the dylib support introduced in D68480 +// This test requires the dylib support introduced in D68480, +// which hasn't shipped yet. +// XFAIL: with_system_cxx_lib=macosx // XFAIL: with_system_cxx_lib=macosx10.15 // XFAIL: with_system_cxx_lib=macosx10.14 // XFAIL: with_system_cxx_lib=macosx10.13 diff --git a/libcxx/test/std/thread/thread.semaphore/release.pass.cpp b/libcxx/test/std/thread/thread.semaphore/release.pass.cpp index bcef4d0..268514c 100644 --- a/libcxx/test/std/thread/thread.semaphore/release.pass.cpp +++ b/libcxx/test/std/thread/thread.semaphore/release.pass.cpp @@ -9,7 +9,9 @@ // UNSUPPORTED: libcpp-has-no-threads // UNSUPPORTED: c++03, c++11 -// This test requires the dylib support introduced in D68480 +// This test requires the dylib support introduced in D68480, +// which hasn't shipped yet. +// XFAIL: with_system_cxx_lib=macosx // XFAIL: with_system_cxx_lib=macosx10.15 // XFAIL: with_system_cxx_lib=macosx10.14 // XFAIL: with_system_cxx_lib=macosx10.13 diff --git a/libcxx/test/std/thread/thread.semaphore/timed.pass.cpp b/libcxx/test/std/thread/thread.semaphore/timed.pass.cpp index acf589a..c46dae5 100644 --- a/libcxx/test/std/thread/thread.semaphore/timed.pass.cpp +++ b/libcxx/test/std/thread/thread.semaphore/timed.pass.cpp @@ -9,7 +9,9 @@ // UNSUPPORTED: libcpp-has-no-threads // UNSUPPORTED: c++03, c++11 -// This test requires the dylib support introduced in D68480 +// This test requires the dylib support introduced in D68480, +// which hasn't shipped yet. +// XFAIL: with_system_cxx_lib=macosx // XFAIL: with_system_cxx_lib=macosx10.15 // XFAIL: with_system_cxx_lib=macosx10.14 // XFAIL: with_system_cxx_lib=macosx10.13 diff --git a/libcxx/test/std/thread/thread.semaphore/try_acquire.pass.cpp b/libcxx/test/std/thread/thread.semaphore/try_acquire.pass.cpp index 4dc86b0..45cdcd4 100644 --- a/libcxx/test/std/thread/thread.semaphore/try_acquire.pass.cpp +++ b/libcxx/test/std/thread/thread.semaphore/try_acquire.pass.cpp @@ -9,7 +9,9 @@ // UNSUPPORTED: libcpp-has-no-threads // UNSUPPORTED: c++03, c++11 -// This test requires the dylib support introduced in D68480 +// This test requires the dylib support introduced in D68480, +// which hasn't shipped yet. +// XFAIL: with_system_cxx_lib=macosx // XFAIL: with_system_cxx_lib=macosx10.15 // XFAIL: with_system_cxx_lib=macosx10.14 // XFAIL: with_system_cxx_lib=macosx10.13 -- 2.7.4