From 0e22b642390204a01617e2424116cfc60953c95c Mon Sep 17 00:00:00 2001 From: Unsung Lee Date: Tue, 16 Apr 2024 19:17:09 +0900 Subject: [PATCH] heart-cpu: Remove double unlock code Rmove double unlock code (i.e., unlock after unlock without getting lock). It causes undefined behavior, so it must be removed. This problem is reported by Coverity with id = 1750882. Change-Id: Ia898cc02846d1cc2a9e0de9e363bfd37b0ca25a2 Signed-off-by: Unsung Lee --- src/resource-monitor/heart-cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/resource-monitor/heart-cpu.c b/src/resource-monitor/heart-cpu.c index 9565d12..8f06914 100644 --- a/src/resource-monitor/heart-cpu.c +++ b/src/resource-monitor/heart-cpu.c @@ -848,7 +848,7 @@ void heart_cpu_update(struct logging_table_form *data, void *user_data) ret = heart_cpu_save_to_file(cache); if (ret) { _E("save to file failed"); - goto unlock_exit; + return; } cache->last_file_commit_time = curr_time; -- 2.7.4