From 0dc06b9a3d57bfe38ba6eebfe99892d15d9da4bb Mon Sep 17 00:00:00 2001 From: Reid Kleckner Date: Mon, 7 Apr 2014 19:27:58 +0000 Subject: [PATCH] -fms-extensions: Don't define __PRETTY_FUNCTION__ to __FUNCTION__ This reverts r90596 from 2009. Having this macro definition makes Clang strictly less useful with -fms-extensions. llvm-svn: 205729 --- clang/lib/Frontend/InitPreprocessor.cpp | 4 ---- clang/test/CodeGen/predefined-expr.c | 1 + 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/clang/lib/Frontend/InitPreprocessor.cpp b/clang/lib/Frontend/InitPreprocessor.cpp index 761dba4..a86fe51 100644 --- a/clang/lib/Frontend/InitPreprocessor.cpp +++ b/clang/lib/Frontend/InitPreprocessor.cpp @@ -508,10 +508,6 @@ static void InitializePredefinedMacros(const TargetInfo &TI, } if (LangOpts.MicrosoftExt) { - // Both __PRETTY_FUNCTION__ and __FUNCTION__ are GCC extensions, however - // VC++ appears to only like __FUNCTION__. - Builder.defineMacro("__PRETTY_FUNCTION__", "__FUNCTION__"); - // Work around some issues with Visual C++ headers. if (LangOpts.WChar) { // wchar_t supported as a keyword. Builder.defineMacro("_WCHAR_T_DEFINED"); diff --git a/clang/test/CodeGen/predefined-expr.c b/clang/test/CodeGen/predefined-expr.c index 3471dcd..6c94152 100644 --- a/clang/test/CodeGen/predefined-expr.c +++ b/clang/test/CodeGen/predefined-expr.c @@ -1,4 +1,5 @@ // RUN: %clang_cc1 %s -emit-llvm -o - | FileCheck %s +// RUN: %clang_cc1 -fms-extensions %s -emit-llvm -o - | FileCheck %s // CHECK: @__func__.plainFunction = private unnamed_addr constant [14 x i8] c"plainFunction\00" // CHECK: @__PRETTY_FUNCTION__.plainFunction = private unnamed_addr constant [21 x i8] c"void plainFunction()\00" -- 2.7.4