From 0d27e6f86ef9719b816a808709d9accddf11cc9f Mon Sep 17 00:00:00 2001 From: Matthew Waters Date: Fri, 15 Jan 2021 20:53:27 +1100 Subject: [PATCH] isomp4: actually make streamable fallback work We weren't setting the fragment_mode field anymore now that the implementation doesn't change based on the value of the streamable property. This lead to invalid files. Part-of: --- gst/isomp4/gstqtmux.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/gst/isomp4/gstqtmux.c b/gst/isomp4/gstqtmux.c index 01e5101..1130071 100644 --- a/gst/isomp4/gstqtmux.c +++ b/gst/isomp4/gstqtmux.c @@ -3077,11 +3077,14 @@ gst_qt_mux_start_file (GstQTMux * qtmux) if (qtmux->fragment_mode == GST_QT_MUX_FRAGMENT_STREAMABLE) break; if (!qtmux->downstream_seekable) { - GST_WARNING_OBJECT (qtmux, "downstream is not seekable, but " - "streamable=false. Will ignore that and create streamable output " - "instead"); - qtmux->streamable = TRUE; - g_object_notify (G_OBJECT (qtmux), "streamable"); + if (qtmux->fragment_mode == GST_QT_MUX_FRAGMENT_DASH_OR_MSS) { + GST_WARNING_OBJECT (qtmux, "downstream is not seekable, but " + "streamable=false. Will ignore that and create streamable output " + "instead"); + qtmux->streamable = TRUE; + g_object_notify (G_OBJECT (qtmux), "streamable"); + qtmux->fragment_mode = GST_QT_MUX_FRAGMENT_STREAMABLE; + } } break; case GST_QT_MUX_MODE_ROBUST_RECORDING_PREFILL: -- 2.7.4