From 0ccdb8cfae55ea58fed8c1bc3960d2f7cc87f617 Mon Sep 17 00:00:00 2001 From: Eunhae Choi Date: Wed, 28 Dec 2016 18:21:07 +0900 Subject: [PATCH] modify comment Change-Id: I0d1c474bdd4aec5bcf839758247468e497214399 (cherry picked from commit 554c110e812c25e4c1c639490d556105372d7f49) --- ext/hls/gsthlsdemux.c | 6 +++--- ext/hls/m3u8.c | 4 ++-- gst/mpegtsdemux/mpegtspacketizer.c | 16 ++++++++-------- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/ext/hls/gsthlsdemux.c b/ext/hls/gsthlsdemux.c index c084615..a36bf73 100644 --- a/ext/hls/gsthlsdemux.c +++ b/ext/hls/gsthlsdemux.c @@ -1007,8 +1007,8 @@ gst_hls_demux_update_playlist (GstHLSDemux * demux, gboolean update, gchar *uri, *main_uri; #ifdef TIZEN_FEATURE_ADAPTIVE_MODIFICATION -//[prasenjit.c]Sometimes for Errornous Clips , when Server changes the playlist abruptly , the URI does not remain valid anymore. -//Adding one error check condition to handle the cases. +/* Sometimes for Errornous Clips , when Server changes the playlist abruptly , the URI does not remain valid anymore. + Adding one error check condition to handle the cases. */ if ((!demux->client->current)||(!demux->client->main)) { GST_WARNING_OBJECT (demux, "Invalid m3u8 instance in playlist .. no update possible !!!"); return FALSE; @@ -1151,7 +1151,7 @@ retry: if (demux->client->sequence >= last_sequence - 3) { demux->client->sequence = MIN(MAX(MAX(first_sequence, last_sequence - 3),previous_sequence),last_sequence); /* - [prasenjit.c] Refer 6.3.5 for draft-pantos-http-live-streaming-19. + Refer 6.3.5 for draft-pantos-http-live-streaming-19. As per specification , "In order to play the presentation normally, the next Media Segment to load is the one with the lowest Media Sequence Number that is greater than the Media Sequence Number of the last Media Segment loaded." diff --git a/ext/hls/m3u8.c b/ext/hls/m3u8.c index 523c25c..7037b78 100644 --- a/ext/hls/m3u8.c +++ b/ext/hls/m3u8.c @@ -887,8 +887,8 @@ gst_m3u8_client_update (GstM3U8Client * self, gchar * data) gint pos = g_list_length (m3u8->files) - GST_M3U8_LIVE_MIN_FRAGMENT_DISTANCE; #ifdef TIZEN_FEATURE_ADAPTIVE_MODIFICATION -/*[shweta.agg] While playing live video in hotstar, Video is starting from beginning.Setting current_file to nth fragment for live streams. - https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/ext/hls/m3u8.c?id=22456ce0328a8d06a12997979a143a0103867a49 +/* While playing live video in hotstar, Video is starting from beginning.Setting current_file to nth fragment for live streams. + https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/ext/hls/m3u8.c?id=22456ce0328a8d06a12997979a143a0103867a49 */ self->current_file = g_list_nth (m3u8->files, pos >= 0 ? pos : 0); #else diff --git a/gst/mpegtsdemux/mpegtspacketizer.c b/gst/mpegtsdemux/mpegtspacketizer.c index e5dc6af..9f6b9bf 100644 --- a/gst/mpegtsdemux/mpegtspacketizer.c +++ b/gst/mpegtsdemux/mpegtspacketizer.c @@ -474,7 +474,7 @@ mpegts_packetizer_parse_adaptation_field_control (MpegTSPacketizer2 * packetizer->is_random_access = TRUE; } /* -[prasenjit.c] For Jio Beats Audio-Only HLS Contents , PCR flags are not getting set. +For Jio Beats Audio-Only HLS Contents , PCR flags are not getting set. As a result , when DRC switch happens , Base Offset not getting updated resulting in timestamp mismatch. Currently have checked for adaptation control flags and if PCR is not getting set along with other flags , Skew calculation is done based on last_in_time. */ @@ -492,7 +492,7 @@ Currently have checked for adaptation control flags and if PCR is not getting se GST_TIME_ARGS (pcrtable->last_pcrtime)); /* -[prasenjit.c] For Hotstar Live Streams , PCR flags comes intermittently. This code was causing skew calculation getting done for those streams , causing invalid timestamps to get passed to Decoder. +For Hotstar Live Streams , PCR flags comes intermittently. This code was causing skew calculation getting done for those streams , causing invalid timestamps to get passed to Decoder. Blocked the code for Live Streams. Additionally , if Skew calculation is already done via this logic , need to disable RA flag to avoid base_time double recalculation. */ @@ -2325,11 +2325,11 @@ mpegts_packetizer_pts_to_ts (MpegTSPacketizer2 * packetizer, * That being said, this will only happen for the small interval of time * where PTS/DTS are wrapping just before we see the first reset/wrap PCR */ - /* - * [prasenjit.c] For some HLS Live servers (e.g tvpstream.tvp.pl ) , we observe erronous PCR values. - * As a result , last_pcrtime comes faulty which causes PTS values not to be calculated at all and buffers are dropped. - * We are currently ignoring the check for handling the erronous server PCR case. - */ + /* + * For some HLS Live servers (e.g tvpstream.tvp.pl ) , we observe erronous PCR values. + * As a result , last_pcrtime comes faulty which causes PTS values not to be calculated at all and buffers are dropped. + * We are currently ignoring the check for handling the erronous server PCR case. + */ #ifdef TIZEN_FEATURE_TSDEMUX_MODIFICATION tmp = pcrtable->base_time + pcrtable->skew; if (packetizer->is_live_stream) @@ -2462,7 +2462,7 @@ mpegts_packetizer_pts_to_ts (MpegTSPacketizer2 * packetizer, res = pts - packetizer->ra_base_time; } else if ((packetizer->is_non_pcr_live_feed) && (GST_CLOCK_TIME_IS_VALID(pts))) { /* - [prasenjit.c] For Live Youtube Channels , PCR flag does not come. + For Live Youtube Channels , PCR flag does not come. Due to this , base offset of the content pts values are not obtained , so playback does not work. Currently based on the flag is_non_pcr_live_feed set in mpegts_packetizer_parse_adaptation_field_control , we are rebasing the pts values. */ -- 2.7.4