From 0ca00c353823627c814fdff70631d15549a7b559 Mon Sep 17 00:00:00 2001 From: Diego Caballero Date: Thu, 16 Dec 2021 09:45:34 +0000 Subject: [PATCH] [mlir][vector] Remove default value in populateVectorMultiReductionLoweringPatterns Having a default value for the lowering strategy of the multi-reduction op has proven to be unexpected by users. This patch is dropping the default value so that users have to explicitly choose the lowering strategy to be applied. Reviewed By: nicolasvasilache Differential Revision: https://reviews.llvm.org/D115805 --- mlir/include/mlir/Dialect/Vector/VectorRewritePatterns.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mlir/include/mlir/Dialect/Vector/VectorRewritePatterns.h b/mlir/include/mlir/Dialect/Vector/VectorRewritePatterns.h index 433ab8d..22c1b4d 100644 --- a/mlir/include/mlir/Dialect/Vector/VectorRewritePatterns.h +++ b/mlir/include/mlir/Dialect/Vector/VectorRewritePatterns.h @@ -157,9 +157,7 @@ void populateVectorTransposeLoweringPatterns( /// the other patterns can kick in, thus fully exiting out of the /// vector.multi_reduction abstraction. void populateVectorMultiReductionLoweringPatterns( - RewritePatternSet &patterns, - VectorMultiReductionLowering options = - VectorMultiReductionLowering::InnerParallel); + RewritePatternSet &patterns, VectorMultiReductionLowering options); /// Collects patterns to progressively lower vector contraction ops on high-D /// into low-D reduction and product ops. -- 2.7.4