From 0c9b039c22d836708431d0ae2af00c23ed40bd01 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Tim-Philipp=20M=C3=BCller?= Date: Sat, 19 Jan 2013 13:27:48 +0000 Subject: [PATCH] pulsesink: don't error out if pa_stream_proplist_update() with new tags fails Shouldn't really happen these days, but if it does, it's not really a problem either. https://bugzilla.gnome.org/show_bug.cgi?id=656068 --- ext/pulse/pulsesink.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/ext/pulse/pulsesink.c b/ext/pulse/pulsesink.c index e6f95a3..0827a06 100644 --- a/ext/pulse/pulsesink.c +++ b/ext/pulse/pulsesink.c @@ -2700,11 +2700,12 @@ gst_pulsesink_change_props (GstPulseSink * psink, GstTagList * l) if (pbuf == NULL || pbuf->stream == NULL) goto no_buffer; + /* We're not interested if this operation failed or not */ if (!(o = pa_stream_proplist_update (pbuf->stream, PA_UPDATE_REPLACE, - pl, NULL, NULL))) - goto update_failed; + pl, NULL, NULL))) { + GST_DEBUG_OBJECT (psink, "pa_stream_proplist_update() failed"); + } - /* We're not interested if this operation failed or not */ unlock: if (o) @@ -2725,13 +2726,6 @@ no_buffer: GST_DEBUG_OBJECT (psink, "we have no ringbuffer"); goto unlock; } -update_failed: - { - GST_ELEMENT_ERROR (psink, RESOURCE, FAILED, - ("pa_stream_proplist_update() failed: %s", - pa_strerror (pa_context_errno (pbuf->context))), (NULL)); - goto unlock; - } } static void -- 2.7.4