From 0c83ddcdf7e931abb8601a030c4676efc196e9be Mon Sep 17 00:00:00 2001 From: Christopher Obbard Date: Tue, 27 Sep 2022 18:17:24 +0100 Subject: [PATCH] v4l2codecs: Warn user when no media devices are found Currently if the user is not able to access the devices under /dev/media*, either due to no media devices present on the system or simply no permission to access the device, v4l2codecs initialises with no features or debug messages. Since calling `GST_DEBUG="v4l2*:7" gst-inspect-1.0 v4l2codecs` is a typical way to diagnose why element(s) failed to enumerate, we should be more verbose here when the user is not able to access any /dev/media* device. So print a simple debug message in this case to aid debugging. Part-of: --- subprojects/gst-plugins-bad/sys/v4l2codecs/gstv4l2codecdevice.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/subprojects/gst-plugins-bad/sys/v4l2codecs/gstv4l2codecdevice.c b/subprojects/gst-plugins-bad/sys/v4l2codecs/gstv4l2codecdevice.c index 7886c79..0497a1a 100644 --- a/subprojects/gst-plugins-bad/sys/v4l2codecs/gstv4l2codecdevice.c +++ b/subprojects/gst-plugins-bad/sys/v4l2codecs/gstv4l2codecdevice.c @@ -316,6 +316,9 @@ gst_v4l2_codec_find_devices (void) client = g_udev_client_new (NULL); udev_devices = g_udev_client_query_by_subsystem (client, "media"); + if (!udev_devices) + GST_DEBUG ("Found no media devices"); + for (d = udev_devices; d; d = g_list_next (d)) { GUdevDevice *udev = (GUdevDevice *) d->data; const gchar *path = g_udev_device_get_device_file (udev); -- 2.7.4