From 0c0fb4b76559db8ba4c6dff9599300b0cc5fe3fe Mon Sep 17 00:00:00 2001 From: Simon Atanasyan Date: Thu, 27 Sep 2018 05:04:50 +0000 Subject: [PATCH] [driver][mips] Adjust target triple accordingly to provided ABI name Explicitly selected MIPS ABI using the `-mabi` option implies corresponding target triple. For 'O32' ABI it's a 32-bit target triple like `mips-linux-gnu`. For 'N32' and 'N64' ABIs it's a 64-bit target triple like `mips64-linux-gnu`. This patch adjusts target triple accordingly these rules like we do for pseudo-target flags '-m64', '-m32' etc already. Differential revision: https://reviews.llvm.org/D52290 llvm-svn: 343169 --- clang/lib/Driver/Driver.cpp | 10 ++++++++++ clang/test/Driver/mips-abi.c | 25 +++++++++++++++++++++++++ 2 files changed, 35 insertions(+) diff --git a/clang/lib/Driver/Driver.cpp b/clang/lib/Driver/Driver.cpp index 4439e72..8266f92 100644 --- a/clang/lib/Driver/Driver.cpp +++ b/clang/lib/Driver/Driver.cpp @@ -481,6 +481,16 @@ static llvm::Triple computeTargetTriple(const Driver &D, Target.setVendorName("intel"); } + // If target is MIPS adjust the target triple + // accordingly to provided ABI name. + A = Args.getLastArg(options::OPT_mabi_EQ); + if (A && Target.isMIPS()) + Target = llvm::StringSwitch(A->getValue()) + .Case("32", Target.get32BitArchVariant()) + .Case("n32", Target.get64BitArchVariant()) + .Case("64", Target.get64BitArchVariant()) + .Default(Target); + return Target; } diff --git a/clang/test/Driver/mips-abi.c b/clang/test/Driver/mips-abi.c index 8591a45..f6987c13 100644 --- a/clang/test/Driver/mips-abi.c +++ b/clang/test/Driver/mips-abi.c @@ -162,3 +162,28 @@ // RUN: -march=unknown 2>&1 \ // RUN: | FileCheck -check-prefix=MIPS-ARCH-UNKNOWN %s // MIPS-ARCH-UNKNOWN: error: unknown target CPU 'unknown' + +// Check adjusting of target triple accordingly to `-mabi` option. +// RUN: %clang -target mips64-linux-gnu -mabi=32 -### %s 2>&1 \ +// RUN: | FileCheck -check-prefix=TARGET-O32 %s +// TARGET-O32: "-triple" "mips-unknown-linux-gnu" +// TARGET-O32: "-target-cpu" "mips32r2" +// TARGET-O32: "-target-abi" "o32" +// TARGET-O32: ld{{.*}}" +// TARGET-O32: "-m" "elf32btsmip" + +// RUN: %clang -target mips-linux-gnu -mabi=n32 -### %s 2>&1 \ +// RUN: | FileCheck -check-prefix=TARGET-N32 %s +// TARGET-N32: "-triple" "mips64-unknown-linux-gnu" +// TARGET-N32: "-target-cpu" "mips64r2" +// TARGET-N32: "-target-abi" "n32" +// TARGET-N32: ld{{.*}}" +// TARGET-N32: "-m" "elf32btsmipn32" + +// RUN: %clang -target mips-linux-gnu -mabi=64 -### %s 2>&1 \ +// RUN: | FileCheck -check-prefix=TARGET-N64 %s +// TARGET-N64: "-triple" "mips64-unknown-linux-gnu" +// TARGET-N64: "-target-cpu" "mips64r2" +// TARGET-N64: "-target-abi" "n64" +// TARGET-N64: ld{{.*}}" +// TARGET-N64: "-m" "elf64btsmip" -- 2.7.4