From 0bb0dff0cc16ac58e3f0123bda3035547da30d55 Mon Sep 17 00:00:00 2001 From: Colin Ian King Date: Wed, 9 Oct 2019 10:46:02 +0100 Subject: [PATCH] staging: wfx: fix swapped arguments in memset call MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The memset appears to have the 2nd and 3rd arguments in the wrong order, fix this by swapping these around into the correct order. Addresses-Coverity: ("Memset fill truncated") Fixes: 4f8b7fabb15d ("staging: wfx: allow to send commands to chip") Signed-off-by: Colin Ian King Reviewed-by: Jérôme Pouiller Link: https://lore.kernel.org/r/20191009094602.19663-1-colin.king@canonical.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/wfx/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wfx/debug.c b/drivers/staging/wfx/debug.c index 8de16ad..761ad9b 100644 --- a/drivers/staging/wfx/debug.c +++ b/drivers/staging/wfx/debug.c @@ -226,7 +226,7 @@ static ssize_t wfx_send_hif_msg_write(struct file *file, const char __user *user // wfx_cmd_send() chekc that reply buffer is wide enough, but do not // return precise length read. User have to know how many bytes should // be read. Filling reply buffer with a memory pattern may help user. - memset(context->reply, sizeof(context->reply), 0xFF); + memset(context->reply, 0xFF, sizeof(context->reply)); request = memdup_user(user_buf, count); if (IS_ERR(request)) return PTR_ERR(request); -- 2.7.4