From 0b69b8384d9b92898ec29f78a2364bec2277e516 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Mon, 16 May 2022 10:42:43 -0700 Subject: [PATCH] [Driver] Change "zlib not installed" diagnostic to "zlib not enabled" The former is a bit misleading and a user may try installing zlib which will not help. --- clang/include/clang/Basic/DiagnosticDriverKinds.td | 2 +- clang/test/Driver/nozlibcompress.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/clang/include/clang/Basic/DiagnosticDriverKinds.td b/clang/include/clang/Basic/DiagnosticDriverKinds.td index e58cfe6..7961b00 100644 --- a/clang/include/clang/Basic/DiagnosticDriverKinds.td +++ b/clang/include/clang/Basic/DiagnosticDriverKinds.td @@ -412,7 +412,7 @@ def warn_missing_sysroot : Warning<"no such sysroot directory: '%0'">, InGroup>; def warn_incompatible_sysroot : Warning<"using sysroot for '%0' but targeting '%1'">, InGroup>; -def warn_debug_compression_unavailable : Warning<"cannot compress debug sections (zlib not installed)">, +def warn_debug_compression_unavailable : Warning<"cannot compress debug sections (zlib not enabled)">, InGroup>; def warn_drv_disabling_vptr_no_rtti_default : Warning< "implicitly disabling vptr sanitizer because rtti wasn't enabled">, diff --git a/clang/test/Driver/nozlibcompress.c b/clang/test/Driver/nozlibcompress.c index 9a704e7..45935f5 100644 --- a/clang/test/Driver/nozlibcompress.c +++ b/clang/test/Driver/nozlibcompress.c @@ -3,5 +3,5 @@ // RUN: %clang -### -fintegrated-as -gz -c %s 2>&1 | FileCheck %s -check-prefix CHECK-WARN // RUN: %clang -### -fintegrated-as -gz=none -c %s 2>&1 | FileCheck -allow-empty -check-prefix CHECK-NOWARN %s -// CHECK-WARN: warning: cannot compress debug sections (zlib not installed) -// CHECK-NOWARN-NOT: warning: cannot compress debug sections (zlib not installed) +// CHECK-WARN: warning: cannot compress debug sections (zlib not enabled) +// CHECK-NOWARN-NOT: warning: cannot compress debug sections (zlib not enabled) -- 2.7.4