From 0abc657914c73c74a7381a26dd45d138a4b3bdd7 Mon Sep 17 00:00:00 2001 From: Luiz Capitulino Date: Fri, 18 Dec 2009 13:25:00 -0200 Subject: [PATCH] QMP: Return an empty dict by default Currently, when a regular command doesn't have any data to output, QMP will emit: { "return": "OK" } Returning an empty dict is better though, because dicts can support some protocol changes in a compatible way. So, with this commit we will return: { "return": {} } Signed-off-by: Luiz Capitulino Signed-off-by: Anthony Liguori --- monitor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index f4d77e2..129badc 100644 --- a/monitor.c +++ b/monitor.c @@ -286,7 +286,8 @@ static void monitor_protocol_emitter(Monitor *mon, QObject *data) qobject_incref(data); qdict_put_obj(qmp, "return", data); } else { - qdict_put(qmp, "return", qstring_from_str("OK")); + /* return an empty QDict by default */ + qdict_put(qmp, "return", qdict_new()); } } else { /* error response */ -- 2.7.4