From 0aba1743611109545bba86bf055a04ecbe210132 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Marek=20Ol=C5=A1=C3=A1k?= Date: Sat, 14 Nov 2020 00:59:56 -0500 Subject: [PATCH] radeonsi: always return void from si_build_wrapper_function It's the end of the shader, there are no return values. Acked-by: Pierre-Eric Pelloux-Prayer Part-of: --- src/gallium/drivers/radeonsi/si_shader_llvm.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_llvm.c b/src/gallium/drivers/radeonsi/si_shader_llvm.c index d327e8a..3a69d1d 100644 --- a/src/gallium/drivers/radeonsi/si_shader_llvm.c +++ b/src/gallium/drivers/radeonsi/si_shader_llvm.c @@ -732,9 +732,6 @@ void si_build_wrapper_function(struct si_shader_context *ctx, LLVMValueRef *part if (ctx->stage == MESA_SHADER_TESS_CTRL && si_is_multi_part_shader(ctx->shader)) ac_build_endif(&ctx->ac, 6507); - /* Return the value from the last part. */ - if (LLVMGetTypeKind(LLVMTypeOf(ret)) == LLVMVoidTypeKind) - LLVMBuildRetVoid(builder); - else - LLVMBuildRet(builder, ret); + assert(LLVMGetTypeKind(LLVMTypeOf(ret)) == LLVMVoidTypeKind); + LLVMBuildRetVoid(builder); } -- 2.7.4