From 0ab88698ae45dca5158b51adbbdb3a81e8513060 Mon Sep 17 00:00:00 2001 From: "rossberg@chromium.org" Date: Wed, 15 Oct 2014 14:17:26 +0000 Subject: [PATCH] Fix verification of Int64Constant TBR=jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/660533002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24641 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/compiler/verifier.cc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc index 8f0b5a2..0400500 100644 --- a/src/compiler/verifier.cc +++ b/src/compiler/verifier.cc @@ -224,7 +224,13 @@ GenericGraphVisit::Control Verifier::Visitor::Pre(Node* node) { // Type is a 32 bit integer, signed or unsigned. CHECK(bounds(node).upper->Is(Type::Integral32())); break; - case IrOpcode::kInt64Constant: // Close enough... + case IrOpcode::kInt64Constant: + // Constants have no inputs. + CHECK_EQ(0, input_count); + // Type is internal. + // TODO(rossberg): Introduce proper Int64 type. + CHECK(bounds(node).upper->Is(Type::Internal())); + break; case IrOpcode::kFloat32Constant: case IrOpcode::kFloat64Constant: case IrOpcode::kNumberConstant: -- 2.7.4