From 0a7ca80360584ff35cb58716e08855a913a3f4d0 Mon Sep 17 00:00:00 2001 From: Jens Massberg Date: Wed, 7 Jun 2023 15:15:07 +0200 Subject: [PATCH] Fix parameter name in Sema::addInitCapture to ByRef. Rename parameter in Sema::addInitCapture as proposed in review of Sema::addInitCapture. Sorry, that I have missed the comment there! Reviewed By: ilya-biryukov Differential Revision: https://reviews.llvm.org/D139541 --- clang/include/clang/Sema/Sema.h | 3 +-- clang/lib/Sema/SemaLambda.cpp | 9 ++++----- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/clang/include/clang/Sema/Sema.h b/clang/include/clang/Sema/Sema.h index cf25f39..a158469 100644 --- a/clang/include/clang/Sema/Sema.h +++ b/clang/include/clang/Sema/Sema.h @@ -7171,8 +7171,7 @@ public: IdentifierInfo *Id, unsigned InitStyle, Expr *Init, DeclContext *DeclCtx); /// Add an init-capture to a lambda scope. - void addInitCapture(sema::LambdaScopeInfo *LSI, VarDecl *Var, - bool isReferenceType); + void addInitCapture(sema::LambdaScopeInfo *LSI, VarDecl *Var, bool ByRef); /// Note that we have finished the explicit captures for the /// given lambda. diff --git a/clang/lib/Sema/SemaLambda.cpp b/clang/lib/Sema/SemaLambda.cpp index 730f70e..c1d70ad 100644 --- a/clang/lib/Sema/SemaLambda.cpp +++ b/clang/lib/Sema/SemaLambda.cpp @@ -798,12 +798,11 @@ VarDecl *Sema::createLambdaInitCaptureVarDecl( return NewVD; } -void Sema::addInitCapture(LambdaScopeInfo *LSI, VarDecl *Var, - bool isReferenceType) { +void Sema::addInitCapture(LambdaScopeInfo *LSI, VarDecl *Var, bool ByRef) { assert(Var->isInitCapture() && "init capture flag should be set"); - LSI->addCapture(Var, /*isBlock*/ false, isReferenceType, - /*isNested*/ false, Var->getLocation(), SourceLocation(), - Var->getType(), /*Invalid*/ false); + LSI->addCapture(Var, /*isBlock=*/false, ByRef, + /*isNested=*/false, Var->getLocation(), SourceLocation(), + Var->getType(), /*Invalid=*/false); } // Unlike getCurLambda, getCurrentLambdaScopeUnsafe doesn't -- 2.7.4