From 0a03b5ef188e6d9dfbbed05652eb63d31db2a7da Mon Sep 17 00:00:00 2001 From: Benedikt Meurer Date: Tue, 23 Dec 2014 12:00:46 +0100 Subject: [PATCH] [turbofan] Turn DCHECK for fixed slot index into a CHECK. This is a temporary workaround to ensure that we crash in release mode instead of running into undefined behavior. BUG=chromium:444681 LOG=y R=ishell@chromium.org Review URL: https://codereview.chromium.org/800713006 Cr-Commit-Position: refs/heads/master@{#25933} --- src/compiler/instruction.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compiler/instruction.h b/src/compiler/instruction.h index 41cda82..4ce89dd 100644 --- a/src/compiler/instruction.h +++ b/src/compiler/instruction.h @@ -129,7 +129,8 @@ class UnallocatedOperand : public InstructionOperand { value_ |= VirtualRegisterField::encode(kInvalidVirtualRegister); value_ |= BasicPolicyField::encode(policy); value_ |= index << FixedSlotIndexField::kShift; - DCHECK(this->fixed_slot_index() == index); + // TODO(dcarney): 2^10 is not enough for the fixed slot index. + CHECK(this->fixed_slot_index() == index); } UnallocatedOperand(ExtendedPolicy policy, int index) -- 2.7.4