From 09f6d1d51eacd4353ea09b2688b54b31b8c88b50 Mon Sep 17 00:00:00 2001 From: Artem Popov Date: Mon, 28 Nov 2016 10:44:59 -0800 Subject: [PATCH] eet: add checking on null to eet_data_write_cipher and EINA_ARG_NONNULL to dump API @fix Summary: add checking on null to eet_data_write_cipher and EINA_ARG_NONNULL to eet_data_dump* and eet_data_test_dump* API Reviewers: NikaWhite, myoungwoon, cedric Reviewed By: cedric Subscribers: jpeg, t.naumenko Differential Revision: https://phab.enlightenment.org/D4433 Change-Id: I1ee0f550aaab3092a9bf192c0d764c8d498c07e8 Signed-off-by: Cedric BAIL --- src/lib/eet/Eet.h | 8 ++++---- src/lib/eet/eet_data.c | 1 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/lib/eet/Eet.h b/src/lib/eet/Eet.h index b5c1ccd..30fc878 100644 --- a/src/lib/eet/Eet.h +++ b/src/lib/eet/Eet.h @@ -3494,7 +3494,7 @@ EAPI int eet_data_text_dump(const void *data_in, int size_in, Eet_Dump_Callback dumpfunc, - void *dumpdata); + void *dumpdata) EINA_ARG_NONNULL(3); /** * Take an ascii encoding from eet_data_text_dump() and re-encode in binary. @@ -3555,7 +3555,7 @@ EAPI int eet_data_dump(Eet_File *ef, const char *name, Eet_Dump_Callback dumpfunc, - void *dumpdata); + void *dumpdata) EINA_ARG_NONNULL(3); /** * Take an ascii encoding from eet_data_dump() and re-encode in binary. @@ -4345,7 +4345,7 @@ eet_data_text_dump_cipher(const void *data_in, const char *cipher_key, int size_in, Eet_Dump_Callback dumpfunc, - void *dumpdata); + void *dumpdata) EINA_ARG_NONNULL(4); /** * Take an ascii encoding from eet_data_text_dump() and re-encode @@ -4412,7 +4412,7 @@ eet_data_dump_cipher(Eet_File *ef, const char *name, const char *cipher_key, Eet_Dump_Callback dumpfunc, - void *dumpdata); + void *dumpdata) EINA_ARG_NONNULL(4); /** * Take an ascii encoding from eet_data_dump() and re-encode in diff --git a/src/lib/eet/eet_data.c b/src/lib/eet/eet_data.c index 02be40b..0d3f27e 100644 --- a/src/lib/eet/eet_data.c +++ b/src/lib/eet/eet_data.c @@ -2389,6 +2389,7 @@ eet_data_write_cipher(Eet_File *ef, int val; EINA_SAFETY_ON_NULL_RETURN_VAL(edd, 0); + EINA_SAFETY_ON_NULL_RETURN_VAL(data, 0); ed = eet_dictionary_get(ef); -- 2.7.4