From 098e935174933dcb3871afb0d51d16cb8acc2401 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 14 Nov 2021 09:32:36 -0800 Subject: [PATCH] [llvm] Use range-based for loops with CallBase::args (NFC) --- llvm/include/llvm/Analysis/ObjCARCAnalysisUtils.h | 4 ++-- llvm/lib/Transforms/IPO/FunctionAttrs.cpp | 4 ++-- llvm/lib/Transforms/Utils/SCCPSolver.cpp | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/llvm/include/llvm/Analysis/ObjCARCAnalysisUtils.h b/llvm/include/llvm/Analysis/ObjCARCAnalysisUtils.h index 87d2c56..17062ab 100644 --- a/llvm/include/llvm/Analysis/ObjCARCAnalysisUtils.h +++ b/llvm/include/llvm/Analysis/ObjCARCAnalysisUtils.h @@ -171,8 +171,8 @@ bool IsPotentialRetainableObjPtr(const Value *Op, AAResults &AA); /// Helper for GetARCInstKind. Determines what kind of construct CS /// is. inline ARCInstKind GetCallSiteClass(const CallBase &CB) { - for (auto I = CB.arg_begin(), E = CB.arg_end(); I != E; ++I) - if (IsPotentialRetainableObjPtr(*I)) + for (const Use &U : CB.args()) + if (IsPotentialRetainableObjPtr(U)) return CB.onlyReadsMemory() ? ARCInstKind::User : ARCInstKind::CallOrUser; return CB.onlyReadsMemory() ? ARCInstKind::None : ARCInstKind::Call; diff --git a/llvm/lib/Transforms/IPO/FunctionAttrs.cpp b/llvm/lib/Transforms/IPO/FunctionAttrs.cpp index 2ad7403..401f988 100644 --- a/llvm/lib/Transforms/IPO/FunctionAttrs.cpp +++ b/llvm/lib/Transforms/IPO/FunctionAttrs.cpp @@ -181,8 +181,8 @@ static MemoryAccessKind checkFunctionMemoryAccess(Function &F, bool ThisBody, // Check whether all pointer arguments point to local memory, and // ignore calls that only access local memory. - for (auto CI = Call->arg_begin(), CE = Call->arg_end(); CI != CE; ++CI) { - Value *Arg = *CI; + for (const Use &U : Call->args()) { + const Value *Arg = U; if (!Arg->getType()->isPtrOrPtrVectorTy()) continue; diff --git a/llvm/lib/Transforms/Utils/SCCPSolver.cpp b/llvm/lib/Transforms/Utils/SCCPSolver.cpp index c7401d7..d7e8eaf 100644 --- a/llvm/lib/Transforms/Utils/SCCPSolver.cpp +++ b/llvm/lib/Transforms/Utils/SCCPSolver.cpp @@ -1197,10 +1197,10 @@ void SCCPInstVisitor::handleCallOverdefined(CallBase &CB) { // a declaration, maybe we can constant fold it. if (F && F->isDeclaration() && canConstantFoldCallTo(&CB, F)) { SmallVector Operands; - for (auto AI = CB.arg_begin(), E = CB.arg_end(); AI != E; ++AI) { - if (AI->get()->getType()->isStructTy()) + for (const Use &A : CB.args()) { + if (A.get()->getType()->isStructTy()) return markOverdefined(&CB); // Can't handle struct args. - ValueLatticeElement State = getValueState(*AI); + ValueLatticeElement State = getValueState(A); if (State.isUnknownOrUndef()) return; // Operands are not resolved yet. -- 2.7.4