From 093b19b09aae1627d270d2db08833bb0f55f1808 Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Sun, 18 Sep 2022 11:02:04 -0700 Subject: [PATCH] egl/dri2: Fix missing return with dri2_egl_error_unlock. Fix defect reported by Coverity Scan. Double unlock (LOCK) double_unlock: dri2_egl_error_unlock unlocks dri2_dpy->lock while it is unlocked. Fixes: f1efe037dfd ("egl/dri2: Add display lock") Signed-off-by: Vinson Lee Reviewed-by: Rob Clark Part-of: --- src/egl/drivers/dri2/egl_dri2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index ba3ea86..bb1c367 100644 --- a/src/egl/drivers/dri2/egl_dri2.c +++ b/src/egl/drivers/dri2/egl_dri2.c @@ -2900,7 +2900,7 @@ dri2_query_dma_buf_modifiers(_EGLDisplay *disp, EGLint format, return dri2_egl_error_unlock(dri2_dpy, EGL_BAD_PARAMETER, "invalid value for max count of formats"); if (max > 0 && modifiers == NULL) - dri2_egl_error_unlock(dri2_dpy, EGL_BAD_PARAMETER, "invalid modifiers array"); + return dri2_egl_error_unlock(dri2_dpy, EGL_BAD_PARAMETER, "invalid modifiers array"); if (dri2_dpy->image->base.version < 15 || dri2_dpy->image->queryDmaBufModifiers == NULL) { -- 2.7.4