From 08d3b0cc99459a14c398d513ca9dcf7fc0c60667 Mon Sep 17 00:00:00 2001 From: Renlin Li Date: Thu, 9 Jun 2016 10:08:08 +0100 Subject: [PATCH] [AARCH64][GAS] Fix two -Wstack-usage warnings. Warning triggerd by gcc 5 with -O0 flag. error: stack usage might be unbounded [-Werror=stack-usage=] gas/ 2016-06-08 Renlin Li * config/tc-aarch64.c (print_operands): Substitute size. (output_operand_error_record): Likewise. --- gas/ChangeLog | 5 +++++ gas/config/tc-aarch64.c | 12 +++++------- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/gas/ChangeLog b/gas/ChangeLog index c3b2436..38d0041 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,8 @@ +2016-06-08 Renlin Li + + * config/tc-aarch64.c (print_operands): Substitute size. + (output_operand_error_record): Likewise. + 2016-06-07 Alan Modra * config/tc-ppc.c (PPC_APUINFO_ISEL, PPC_APUINFO_PMR, diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c index 00a931e..774494f 100644 --- a/gas/config/tc-aarch64.c +++ b/gas/config/tc-aarch64.c @@ -4231,8 +4231,7 @@ print_operands (char *buf, const aarch64_opcode *opcode, for (i = 0; i < AARCH64_MAX_OPND_NUM; ++i) { - const size_t size = 128; - char str[size]; + char str[128]; /* We regard the opcode operand info more, however we also look into the inst->operands to support the disassembling of the optional @@ -4244,7 +4243,7 @@ print_operands (char *buf, const aarch64_opcode *opcode, break; /* Generate the operand string in STR. */ - aarch64_print_operand (str, size, 0, opcode, opnds, i, NULL, NULL); + aarch64_print_operand (str, sizeof (str), 0, opcode, opnds, i, NULL, NULL); /* Delimiter. */ if (str[0] != '\0') @@ -4350,8 +4349,7 @@ output_operand_error_record (const operand_error_record *record, char *str) size_t len = strlen (get_mnemonic_name (str)); int i, qlf_idx; bfd_boolean result; - const size_t size = 2048; - char buf[size]; + char buf[2048]; aarch64_inst *inst_base = &inst.base; const aarch64_opnd_qualifier_seq_t *qualifiers_list; @@ -4381,7 +4379,7 @@ output_operand_error_record (const operand_error_record *record, char *str) /* Print the hint. */ output_info (_(" did you mean this?")); - snprintf (buf, size, "\t%s", get_mnemonic_name (str)); + snprintf (buf, sizeof (buf), "\t%s", get_mnemonic_name (str)); print_operands (buf, opcode, inst_base->operands); output_info (_(" %s"), buf); @@ -4402,7 +4400,7 @@ output_operand_error_record (const operand_error_record *record, char *str) if (i != qlf_idx) { /* Mnemonics name. */ - snprintf (buf, size, "\t%s", get_mnemonic_name (str)); + snprintf (buf, sizeof (buf), "\t%s", get_mnemonic_name (str)); /* Assign the qualifiers. */ assign_qualifier_sequence (inst_base, *qualifiers_list); -- 2.7.4