From 08d16c64ad81b80bf890670483d1c2282df8aea0 Mon Sep 17 00:00:00 2001 From: "jh5.cho" Date: Mon, 30 May 2016 17:26:39 +0900 Subject: [PATCH] [Device] Apply SE Usability Review - BatteryChangingStateChangedEventArgs, change the property name from Changing to IsCharging - Use Color class insted of using unsigned int type of color Change-Id: Id6b9e3afae7e8bd628a435377444e7d52732690f Signed-off-by: Praveen Gattu --- Tizen.System/Device/Battery.cs | 2 +- Tizen.System/Device/DeviceEventArgs.cs | 2 +- Tizen.System/Device/Led.cs | 6 +++--- Tizen.System/Tizen.System.csproj | 3 +++ packaging/csapi-system.spec | 1 + 5 files changed, 9 insertions(+), 5 deletions(-) mode change 100644 => 100755 Tizen.System/Device/Battery.cs mode change 100644 => 100755 Tizen.System/Device/Led.cs mode change 100644 => 100755 Tizen.System/Tizen.System.csproj diff --git a/Tizen.System/Device/Battery.cs b/Tizen.System/Device/Battery.cs old mode 100644 new mode 100755 index 40f0ad9..f26dba5 --- a/Tizen.System/Device/Battery.cs +++ b/Tizen.System/Device/Battery.cs @@ -241,7 +241,7 @@ namespace Tizen.System bool val = (value.ToInt32() == 1); BatteryChargingStateChangedEventArgs e = new BatteryChargingStateChangedEventArgs() { - Charging = val + IsCharging = val }; s_chargingStateChanged?.Invoke(null, e); return true; diff --git a/Tizen.System/Device/DeviceEventArgs.cs b/Tizen.System/Device/DeviceEventArgs.cs index 1e2d94d..6812c39 100644 --- a/Tizen.System/Device/DeviceEventArgs.cs +++ b/Tizen.System/Device/DeviceEventArgs.cs @@ -25,7 +25,7 @@ namespace Tizen.System /// /// The charging state of the battery. Charging is of type boolean which indicates true/false based on currrent charging status. /// - public bool Charging { get; internal set; } + public bool IsCharging { get; internal set; } } // Display diff --git a/Tizen.System/Device/Led.cs b/Tizen.System/Device/Led.cs old mode 100644 new mode 100755 index d17044e..5eb0f5a --- a/Tizen.System/Device/Led.cs +++ b/Tizen.System/Device/Led.cs @@ -1,5 +1,5 @@ using System; - +using Tizen.UI; namespace Tizen.System { /// @@ -56,10 +56,10 @@ namespace Tizen.System /// The Color value /// The first byte means opaque and the other 3 bytes are RGB values. /// - public static void Play(int on, int off, uint color) + public static void Play(int on, int off, Color color) { //looks like only blink option is supported. So hard coded to default blink option. - DeviceError res = (DeviceError)Interop.Device.DeviceLedPlayCustom(on, off, color, 1); + DeviceError res = (DeviceError)Interop.Device.DeviceLedPlayCustom(on, off, Convert.ToUInt32(color.Argb), 1); if (res != DeviceError.None) { throw DeviceExceptionFactory.CreateException(res, "failed to play Led."); diff --git a/Tizen.System/Tizen.System.csproj b/Tizen.System/Tizen.System.csproj old mode 100644 new mode 100755 index b4a29b4..6b0f8d3 --- a/Tizen.System/Tizen.System.csproj +++ b/Tizen.System/Tizen.System.csproj @@ -53,6 +53,9 @@ ..\..\tizen\Tizen\bin\Debug\Tizen.dll + + ..\..\uifw\Tizen.UI\bin\Debug\Tizen.UI.dll + diff --git a/packaging/csapi-system.spec b/packaging/csapi-system.spec index c8b9fc1..c1b3aa6 100755 --- a/packaging/csapi-system.spec +++ b/packaging/csapi-system.spec @@ -17,6 +17,7 @@ BuildRequires: mono-devel # P/Invoke Dependencies BuildRequires: pkgconfig(csapi-tizen) +BuildRequires: pkgconfig(csapi-uifw) BuildRequires: pkgconfig(capi-system-device) BuildRequires: pkgconfig(capi-system-runtime-info) BuildRequires: pkgconfig(capi-system-info) -- 2.34.1